Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Add missing private dns zones to applicable policy assignment and module #903

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

oZakari
Copy link
Contributor

@oZakari oZakari commented Nov 15, 2024

Overview/Summary

This pull request includes significant updates to the infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep file and related documentation. The main changes involve adding a new parameter for the location of Private DNS Zones, updating the list of Private DNS Zones, and modifying policy assignment parameters.

Key Changes:

Parameter Additions:

  • Added parPrivateDnsZonesLocation parameter to specify the location of Private DNS Zones.

Variable Updates:

  • Introduced varGeoCodes mapping for various geographic codes and varSelectedGeoCode to select the appropriate code based on the location parameter.

Private DNS Zones List:

  • Updated the varPrivateDnsZonesFinalResourceIds to include new Private DNS Zones and removed some existing ones.

Policy Assignment Parameters:

  • Modified the modPolicyAssignmentConnDeployPrivateDnsZones module to reflect the updated list of Private DNS Zones in the policy assignment parameters.

Documentation:

  • Updated the generateddocs/alzDefaultPolicyAssignments.bicep.md file to include the new parPrivateDnsZonesLocation parameter.

Related Issues/Work Items

Fixes #897

This PR fixes/adds/changes/removes

  1. Adds all missing dns zones from policy set definition file

Breaking Changes

None

Testing Evidence

Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).

As part of this Pull Request I have

@oZakari oZakari added Area: Policy 📝 Issues / PR's related to Policy Type: Bug 🪲 Something isn't working labels Nov 15, 2024
@oZakari oZakari changed the title Fix dns policy assignment fix: Update private dns zone policy Nov 15, 2024
@oZakari oZakari changed the title fix: Update private dns zone policy fix: Add missing private dns zones to applicable policy assignment and module Nov 15, 2024
@oZakari
Copy link
Contributor Author

oZakari commented Nov 15, 2024

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@oZakari
Copy link
Contributor Author

oZakari commented Nov 15, 2024

/azp run validateazcloud

Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Policy 📝 Issues / PR's related to Policy Type: Bug 🪲 Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Azure Policy Assignment - Configure Azure PaaS services to use private DNS zones
1 participant