-
Notifications
You must be signed in to change notification settings - Fork 514
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Add missing private dns zones to applicable policy assignment and module #903
Open
oZakari
wants to merge
9
commits into
main
Choose a base branch
from
fix-dns-policy-assignment
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+333
−244
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oZakari
added
Area: Policy 📝
Issues / PR's related to Policy
Type: Bug 🪲
Something isn't working
labels
Nov 15, 2024
oZakari
force-pushed
the
fix-dns-policy-assignment
branch
from
November 15, 2024 23:08
9537788
to
cb4a19e
Compare
oZakari
changed the title
Fix dns policy assignment
fix: Update private dns zone policy
Nov 15, 2024
oZakari
changed the title
fix: Update private dns zone policy
fix: Add missing private dns zones to applicable policy assignment and module
Nov 15, 2024
oZakari
force-pushed
the
fix-dns-policy-assignment
branch
from
November 15, 2024 23:38
bcc8d25
to
17e84f7
Compare
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run validateazcloud |
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
This pull request includes significant updates to the
infra-as-code/bicep/modules/policy/assignments/alzDefaults/alzDefaultPolicyAssignments.bicep
file and related documentation. The main changes involve adding a new parameter for the location of Private DNS Zones, updating the list of Private DNS Zones, and modifying policy assignment parameters.Key Changes:
Parameter Additions:
parPrivateDnsZonesLocation
parameter to specify the location of Private DNS Zones.Variable Updates:
varGeoCodes
mapping for various geographic codes andvarSelectedGeoCode
to select the appropriate code based on the location parameter.Private DNS Zones List:
varPrivateDnsZonesFinalResourceIds
to include new Private DNS Zones and removed some existing ones.Policy Assignment Parameters:
modPolicyAssignmentConnDeployPrivateDnsZones
module to reflect the updated list of Private DNS Zones in the policy assignment parameters.Documentation:
generateddocs/alzDefaultPolicyAssignments.bicep.md
file to include the newparPrivateDnsZonesLocation
parameter.Related Issues/Work Items
Fixes #897
This PR fixes/adds/changes/removes
Breaking Changes
None
Testing Evidence
Replace this with any testing evidence to show that your Pull Request works/fixes as described and planned (include screenshots, if appropriate).
As part of this Pull Request I have
.bicep
file/s I am adding/editing are using the latest API version possiblemain
branch