Custom role definition as user-defined type #673
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview/Summary
The module for customRoleDefinitions currently includes the CAF recommended custom roles, with no way to add additional roles. Customers who would like more custom roles have these options:
config/custom-modules
and maintain it themselvesThis issue of no clear way to extend the usage of the module is also found in #646
This PR aims to allow extention of the module, with more custom roles through the parameter file. This together with a user-defined type for customRoles adds IntelliSense when using bicepparam instead of json for the parameterfile. The parameter
parAdditionalRoles
is added and prefilled with example roles as of now.Now the drawback of this approach is that roleDefinitions isn't seperated into their own file, everything is just mashed together into one big parameterfile.
I'm looking for feedback on this approach. Would it be bad design to not keep roleDefs in their own file? Should the CAF recommended custom roles be included in the parameter aswell or should they be held separately?
Please mark the PR don't merge.
This PR fixes/adds/changes/removes
Instead of customers changing the released module this PR opens the possibility to add more custom roles through the parameter file.
Breaking Changes