-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update readme to explain the tls feature support status now for enterprise tier #16
base: main
Are you sure you want to change the base?
Conversation
@selvasingh would you please take a look? |
README.md
Outdated
```bash | ||
az spring app create --name greeting-external-service-v2 \ | ||
--instance-count 1 --memory 2 --jvm-options='-Xms2048m -Xmx2048m -XX:+UnlockExperimentalVMOptions -XX:+UseCGroupMemoryLimitForHeap -XX:+UseG1GC -Djava.awt.headless=true -Dreactor.netty.http.server.accessLogEnabled=true' \ | ||
--persistent-storage ${STORAGE_JSON_FILE} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we able to replace this by "az spring app append-persistent-storage" command, in order to pass thru those variables. (currently if customer change the value of "SHARE_NAME=cacerts", they need to change the byos.json file content as well, which might be not that straightforward)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, that's better. Updated
Purpose
Does this introduce a breaking change?
Pull Request Type
What kind of change does this Pull Request introduce?
How to Test
What to Check
Verify that the following are valid
Other Information