Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #15

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #15

wants to merge 1 commit into from

Conversation

valnav
Copy link

@valnav valnav commented Apr 11, 2019

adding information about validate authority and china cloud

@jmprieur
Copy link
Contributor

LGTM, but @danieldobalian is the SME for Apple.

> [!NOTE]
>developers using the [Azure China Environment](https://docs.microsoft.com/en-us/azure/active-directory/develop/authentication-national-cloud), MUST use <your-tenant-name>.b2clogin.cn) authority, instead of `login.chinacloudapi.cn`.
>
> In order to use <your-tenant-name>.b2clogin.*, you will need to `setValidateAuthority(false)`. Learn more about using [b2clogin](https://docs.microsoft.com/en-us/azure/active-directory-b2c/b2clogin).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We changed this in the latest MSAL 0.4.0 release. validateAuthority flag is now deprecated and you need to pass your authority into the "knownAuthorities" array in the MSALPublicClientApplicationConfig to support this

@jennyf19
Copy link
Contributor

@valnav is this still relevant?

@jennyf19
Copy link
Contributor

@oldalton can this be closed?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants