Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Sync from noir #10110

Closed
wants to merge 54 commits into from
Closed

feat: Sync from noir #10110

wants to merge 54 commits into from

Conversation

AztecBot
Copy link
Collaborator

@AztecBot AztecBot commented Nov 21, 2024

Automated pull of development from the noir programming language, a dependency of Aztec.
BEGIN_COMMIT_OVERRIDE
chore: pin foundry version in CI (noir-lang/noir#6642)
feat(ssa): Deduplicate intrinsics with predicates (noir-lang/noir#6615)
chore: improve error message of &T (noir-lang/noir#6633)
fix: LSP code action wasn't triggering on beginning or end of identifier (noir-lang/noir#6616)
chore!: remove ec module from stdlib (noir-lang/noir#6612)
fix(LSP): use generic self type to narrow down methods to complete (noir-lang/noir#6617)
fix!: Disallow #[export] on associated methods (noir-lang/noir#6626)
chore: redo typo PR by donatik27 (noir-lang/noir#6575)
chore: redo typo PR by Dimitrolito (noir-lang/noir#6614)
feat: simplify jmpifs by reversing branches if condition is negated (noir-lang/noir#5891)
fix: Do not warn on unused functions marked with #[export] (noir-lang/noir#6625)
chore: Add panic for compiler error described in #6620 (noir-lang/noir#6621)
feat(perf): Track last loads per block in mem2reg and remove them if possible (noir-lang/noir#6088)
fix(ssa): Track all local allocations during flattening (noir-lang/noir#6619)
feat(comptime): Implement blackbox functions in comptime interpreter (noir-lang/noir#6551)
chore: derive PartialEq and Hash for FieldElement (noir-lang/noir#6610)
chore: ignore almost-empty directories in nargo_cli tests (noir-lang/noir#6611)
chore: remove temporary allocations from num_bits (noir-lang/noir#6600)
chore: Release Noir(1.0.0-beta.0) (noir-lang/noir#6562)
feat: Add array_refcount and slice_refcount builtins for debugging (noir-lang/noir#6584)
chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove compiler_version from new Nargo.toml (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments (noir-lang/noir#6548)
fix: correct type when simplifying derive_pedersen_generators (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
END_COMMIT_OVERRIDE

AztecBot and others added 26 commits November 21, 2024 15:47
…ents (noir-lang/noir#6548)

fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
…r-lang/noir#6590)

feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
…6590)

feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
…for debugging (noir-lang/noir#6584)

chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
noir-lang/noir#6584)

chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
…for debugging (noir-lang/noir#6584)

chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
noir-lang/noir#6584)

chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
…for debugging (noir-lang/noir#6584)

chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
noir-lang/noir#6584)

chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
…interpreter (noir-lang/noir#6551)

chore: derive PartialEq and Hash for FieldElement (noir-lang/noir#6610)
chore: ignore almost-empty directories in nargo_cli tests (noir-lang/noir#6611)
chore: remove temporary allocations from `num_bits` (noir-lang/noir#6600)
chore: Release Noir(1.0.0-beta.0) (noir-lang/noir#6562)
feat: Add `array_refcount` and `slice_refcount` builtins for debugging (noir-lang/noir#6584)
chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
…oir-lang/noir#6551)

chore: derive PartialEq and Hash for FieldElement (noir-lang/noir#6610)
chore: ignore almost-empty directories in nargo_cli tests (noir-lang/noir#6611)
chore: remove temporary allocations from `num_bits` (noir-lang/noir#6600)
chore: Release Noir(1.0.0-beta.0) (noir-lang/noir#6562)
feat: Add `array_refcount` and `slice_refcount` builtins for debugging (noir-lang/noir#6584)
chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
…oir-lang/noir#6619)

feat(comptime): Implement blackbox functions in comptime interpreter (noir-lang/noir#6551)
chore: derive PartialEq and Hash for FieldElement (noir-lang/noir#6610)
chore: ignore almost-empty directories in nargo_cli tests (noir-lang/noir#6611)
chore: remove temporary allocations from `num_bits` (noir-lang/noir#6600)
chore: Release Noir(1.0.0-beta.0) (noir-lang/noir#6562)
feat: Add `array_refcount` and `slice_refcount` builtins for debugging (noir-lang/noir#6584)
chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
…ir#6619)

feat(comptime): Implement blackbox functions in comptime interpreter (noir-lang/noir#6551)
chore: derive PartialEq and Hash for FieldElement (noir-lang/noir#6610)
chore: ignore almost-empty directories in nargo_cli tests (noir-lang/noir#6611)
chore: remove temporary allocations from `num_bits` (noir-lang/noir#6600)
chore: Release Noir(1.0.0-beta.0) (noir-lang/noir#6562)
feat: Add `array_refcount` and `slice_refcount` builtins for debugging (noir-lang/noir#6584)
chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
* master: (64 commits)
  fix: docker compose aztec up fix (#10197)
  fix: aztec-nargo curl in the earthfile also (#10199)
  chore: fix devbox (#10201)
  chore: misc cleanup (#10194)
  fix: release l1-contracts (#10095)
  git subrepo push --branch=master noir-projects/aztec-nr
  git_subrepo.sh: Fix parent in .gitrepo file. [skip ci]
  chore: replace relative paths to noir-protocol-circuits
  git subrepo push --branch=master barretenberg
  feat: Origin tags implemented in biggroup (#10002)
  fix: Revert "feat: blobs. (#9302)" (#10187)
  feat!: remove SharedImmutable (#10183)
  fix(bb.js): don't minify bb.js - webpack config (#10170)
  feat: blobs. (#9302)
  chore(avm): operands reordering (#10182)
  feat: UltraRollupRecursiveFlavor (#10088)
  feat: one liner for nodes to join rough-rhino (#10168)
  feat!: rename sharedimmutable methods (#10164)
  chore(master): Release 0.64.0 (#10043)
  feat: e2e metrics reporting (#9776)
  ...
fix(LSP): use generic self type to narrow down methods to complete (noir-lang/noir#6617)
fix!: Disallow `#[export]` on associated methods (noir-lang/noir#6626)
chore: redo typo PR by donatik27 (noir-lang/noir#6575)
chore: redo typo PR by Dimitrolito (noir-lang/noir#6614)
feat: simplify `jmpif`s by reversing branches if condition is negated (noir-lang/noir#5891)
fix: Do not warn on unused functions marked with #[export] (noir-lang/noir#6625)
chore: Add panic for compiler error described in #6620 (noir-lang/noir#6621)
feat(perf): Track last loads per block in mem2reg and remove them if possible (noir-lang/noir#6088)
fix(ssa): Track all local allocations during flattening (noir-lang/noir#6619)
feat(comptime): Implement blackbox functions in comptime interpreter (noir-lang/noir#6551)
chore: derive PartialEq and Hash for FieldElement (noir-lang/noir#6610)
chore: ignore almost-empty directories in nargo_cli tests (noir-lang/noir#6611)
chore: remove temporary allocations from `num_bits` (noir-lang/noir#6600)
chore: Release Noir(1.0.0-beta.0) (noir-lang/noir#6562)
feat: Add `array_refcount` and `slice_refcount` builtins for debugging (noir-lang/noir#6584)
chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
fix(LSP): use generic self type to narrow down methods to complete (noir-lang/noir#6617)
fix!: Disallow `#[export]` on associated methods (noir-lang/noir#6626)
chore: redo typo PR by donatik27 (noir-lang/noir#6575)
chore: redo typo PR by Dimitrolito (noir-lang/noir#6614)
feat: simplify `jmpif`s by reversing branches if condition is negated (noir-lang/noir#5891)
fix: Do not warn on unused functions marked with #[export] (noir-lang/noir#6625)
chore: Add panic for compiler error described in #6620 (noir-lang/noir#6621)
feat(perf): Track last loads per block in mem2reg and remove them if possible (noir-lang/noir#6088)
fix(ssa): Track all local allocations during flattening (noir-lang/noir#6619)
feat(comptime): Implement blackbox functions in comptime interpreter (noir-lang/noir#6551)
chore: derive PartialEq and Hash for FieldElement (noir-lang/noir#6610)
chore: ignore almost-empty directories in nargo_cli tests (noir-lang/noir#6611)
chore: remove temporary allocations from `num_bits` (noir-lang/noir#6600)
chore: Release Noir(1.0.0-beta.0) (noir-lang/noir#6562)
feat: Add `array_refcount` and `slice_refcount` builtins for debugging (noir-lang/noir#6584)
chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
Copy link
Contributor

github-actions bot commented Nov 27, 2024

Changes to public function bytecode sizes

Generated at commit: f4ab0ff7a8063ef04a2246c7014bfe1b94fc3725, compared to commit: 3d113b212b4641b2a97e6b2b0b4835908f3957c8

🧾 Summary (100% most significant diffs)

Program Bytecode size in bytes (+/-) %
TokenBridge::exit_to_l1_public +124 ❌ +1.96%
Lending::withdraw_public +4 ❌ +0.21%
Lending::borrow_public +4 ❌ +0.21%
FPC::prepare_fee +4 ❌ +0.20%
FPC::pay_refund +4 ❌ +0.20%
StaticParent::public_nested_static_call +4 ❌ +0.19%
Parent::public_static_call -4 ✅ -0.35%
StaticParent::public_static_call -4 ✅ -0.35%
ImportTest::public_dispatch -4 ✅ -0.38%
AvmTest::u128_from_integer_overflow -4 ✅ -0.49%
Uniswap::_assert_token_is_same -4 ✅ -0.55%
AvmTest::u128_addition_overflow -8 ✅ -0.60%
DocsExample::get_public_immutable_constrained_public_indirect -4 ✅ -0.61%
AuthWitTest::consume_public -4 ✅ -0.64%
Child::set_value_twice_with_nested_last -4 ✅ -0.67%
Child::set_value_twice_with_nested_first -4 ✅ -0.67%
Parent::pub_entry_point -4 ✅ -0.69%
StaticParent::public_call -4 ✅ -0.69%
AvmTest::nested_static_call_to_add -4 ✅ -0.70%
AvmTest::nested_call_to_add -4 ✅ -0.70%
AvmTest::nested_call_to_assert_same -4 ✅ -0.70%
AvmTest::keccak_hash -17 ✅ -0.71%
StaticParent::public_get_value_from_child -4 ✅ -0.72%
AvmTest::nested_call_to_add_with_gas -4 ✅ -0.73%
AvmTest::emit_unencrypted_log -21 ✅ -0.76%
AvmTest::create_different_nullifier_in_nested_call -4 ✅ -0.80%
Router::_check_timestamp -8 ✅ -0.81%
AvmTest::create_same_nullifier_in_nested_call -4 ✅ -0.82%
Router::_check_block_number -8 ✅ -0.82%
ImportTest::pub_call_public_fn -4 ✅ -0.83%
AvmTest::nested_static_call_to_set_storage -4 ✅ -0.83%
Child::set_value_with_two_nested_calls -8 ✅ -0.85%
AvmTest::nested_call_to_nothing -4 ✅ -0.85%
AvmTest::external_call_to_assertion_failure -4 ✅ -0.85%
AvmTest::external_call_to_divide_by_zero -4 ✅ -0.85%
Test::emit_unencrypted -13 ✅ -0.88%
NFT::_store_payload_in_transient_storage_unsafe -13 ✅ -1.10%
Token::_store_payload_in_transient_storage_unsafe -13 ✅ -1.10%
TestLog::emit_unencrypted_events -13 ✅ -1.13%
TokenBlacklist::constructor -79 ✅ -1.27%
Parent::pub_entry_point_twice -13 ✅ -1.32%
CardGame::on_cards_claimed -108 ✅ -1.48%
Auth::set_authorized_delay -69 ✅ -1.49%
Auth::set_authorized -74 ✅ -1.62%
Lending::_withdraw -141 ✅ -1.63%
StaticParent::public_dispatch -98 ✅ -1.69%
Lending::update_accumulator -99 ✅ -1.72%
AvmTest::sha256_hash -68 ✅ -1.73%
Token::constructor -73 ✅ -1.77%
NFT::constructor -73 ✅ -1.80%
TokenBlacklist::mint_private -69 ✅ -1.84%
Lending::_borrow -149 ✅ -2.01%
TokenBlacklist::update_roles -125 ✅ -2.03%
Uniswap::swap_public -318 ✅ -2.08%
CardGame::on_game_joined -110 ✅ -2.16%
Lending::deposit_public -57 ✅ -2.18%
TokenBlacklist::shield -127 ✅ -2.19%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 -137 ✅ -2.20%
AppSubscription::constructor -64 ✅ -2.26%
TokenBlacklist::transfer_public -127 ✅ -2.26%
Lending::repay_public -57 ✅ -2.28%
NFT::transfer_in_public -77 ✅ -2.31%
AuthWitTest::public_dispatch -39 ✅ -2.35%
Crowdfunding::init -64 ✅ -2.36%
Auth::public_dispatch -209 ✅ -2.38%
TokenBlacklist::burn_public -127 ✅ -2.42%
StatefulTest::public_constructor -68 ✅ -2.44%
AppSubscription::public_dispatch -99 ✅ -2.48%
Lending::_repay -141 ✅ -2.48%
TokenBlacklist::get_roles -69 ✅ -2.57%
AvmTest::bulk_testing -603 ✅ -2.61%
Auth::constructor -64 ✅ -2.66%
EasyPrivateVoting::constructor -64 ✅ -2.66%
Uniswap::constructor -64 ✅ -2.71%
Crowdfunding::_publish_donation_receipts -26 ✅ -2.73%
Uniswap::public_dispatch -640 ✅ -2.77%
Lending::init -82 ✅ -2.77%
InclusionProofs::constructor -64 ✅ -2.78%
AvmInitializerTest::public_dispatch -77 ✅ -2.84%
TokenBlacklist::mint_public -115 ✅ -2.87%
Test::consume_message_from_arbitrary_sender_public -228 ✅ -2.87%
Token::transfer_in_public -123 ✅ -2.91%
Token::burn_public -123 ✅ -2.94%
TokenBlacklist::public_dispatch -699 ✅ -3.01%
Token::complete_refund -166 ✅ -3.02%
Parent::public_dispatch -244 ✅ -3.16%
AvmTest::public_dispatch -2,110 ✅ -3.47%
TokenBridge::claim_public -401 ✅ -3.52%
AuthRegistry::public_dispatch -283 ✅ -3.56%
Lending::_deposit -91 ✅ -3.57%
Router::public_dispatch -86 ✅ -3.64%
Test::consume_mint_to_public_message -397 ✅ -3.65%
Claim::constructor -90 ✅ -3.67%
FeeJuice::check_balance -82 ✅ -3.68%
FeeJuice::_increase_public_balance -82 ✅ -3.69%
Token::public_dispatch -1,174 ✅ -3.71%
Lending::get_asset -82 ✅ -3.72%
PriceFeed::public_dispatch -116 ✅ -3.74%
AuthRegistry::consume -110 ✅ -3.75%
Auth::get_authorized_delay -77 ✅ -3.75%
Claim::public_dispatch -124 ✅ -3.81%
TokenBridge::constructor -90 ✅ -3.82%
FPC::constructor -90 ✅ -3.88%
AvmInitializerTest::constructor -77 ✅ -3.94%
EasyPrivateVoting::add_to_tally_public -82 ✅ -3.98%
Auth::get_authorized -77 ✅ -4.03%
Crowdfunding::public_dispatch -189 ✅ -4.04%
Auth::get_scheduled_authorized -77 ✅ -4.25%
AvmTest::get_args_hash -77 ✅ -4.27%
Spam::public_dispatch -139 ✅ -4.28%
AuthRegistry::is_consumable -82 ✅ -4.29%
AuthRegistry::_set_authorized -82 ✅ -4.30%
AvmTest::add_storage_map -82 ✅ -4.30%
TokenBlacklist::balance_of_public -82 ✅ -4.31%
Token::balance_of_public -82 ✅ -4.31%
Spam::public_spam -105 ✅ -4.31%
StatefulTest::public_dispatch -266 ✅ -4.33%
TokenBridge::public_dispatch -901 ✅ -4.34%
Token::_finalize_transfer_to_private_unsafe -294 ✅ -4.40%
AuthRegistry::set_authorized -82 ✅ -4.41%
Token::finalize_transfer_to_private -294 ✅ -4.43%
FeeJuice::balance_of_public -82 ✅ -4.43%
Test::public_dispatch -853 ✅ -4.46%
Token::mint_to_public -128 ✅ -4.46%
Parent::public_nested_static_call -154 ✅ -4.49%
CardGame::on_card_played -270 ✅ -4.50%
Lending::get_position -226 ✅ -4.51%
PriceFeed::set_price -82 ✅ -4.53%
NFT::set_minter -82 ✅ -4.53%
Token::set_minter -82 ✅ -4.53%
NFT::is_minter -82 ✅ -4.54%
Token::is_minter -82 ✅ -4.54%
AvmTest::set_storage_map -82 ✅ -4.55%
Benchmarking::increment_balance -109 ✅ -4.56%
NFT::_finish_transfer_to_public -82 ✅ -4.58%
Benchmarking::broadcast -82 ✅ -4.61%
PriceFeed::get_price -82 ✅ -4.66%
StatefulTest::increment_public_value -82 ✅ -4.67%
AuthRegistry::is_reject_all -82 ✅ -4.68%
StatefulTest::get_public_value -82 ✅ -4.71%
Token::_finalize_mint_to_private_unsafe -298 ✅ -4.71%
AvmTest::poseidon2_hash -82 ✅ -4.73%
Token::finalize_mint_to_private -298 ✅ -4.74%
AvmTest::read_storage_map -82 ✅ -4.79%
AuthRegistry::set_reject_all -82 ✅ -4.80%
StatefulTest::increment_public_value_no_init_check -82 ✅ -4.80%
TestLog::public_dispatch -119 ✅ -5.00%
FeeJuice::public_dispatch -266 ✅ -5.03%
NFT::public_dispatch -1,200 ✅ -5.04%
Lending::public_dispatch -1,379 ✅ -5.04%
Child::public_dispatch -242 ✅ -5.07%
TokenBlacklist::_increase_public_balance -128 ✅ -5.13%
Token::_increase_public_balance -128 ✅ -5.13%
NFT::_finalize_transfer_to_private_unsafe -298 ✅ -5.28%
NFT::mint -151 ✅ -5.31%
NFT::finalize_transfer_to_private -298 ✅ -5.33%
CardGame::public_dispatch -886 ✅ -5.47%
FPC::public_dispatch -408 ✅ -5.62%
InclusionProofs::public_dispatch -212 ✅ -5.64%
CardGame::start_game -420 ✅ -5.86%
StaticChild::public_dispatch -124 ✅ -5.87%
AvmTest::returndata_copy_oracle -111 ✅ -6.06%
NFT::owner_of -151 ✅ -6.20%
Benchmarking::public_dispatch -291 ✅ -7.33%
DocsExample::public_dispatch -350 ✅ -8.25%
EasyPrivateVoting::public_dispatch -523 ✅ -10.05%
Lending::get_assets -86 ✅ -16.60%

Full diff report 👇
Program Bytecode size in bytes (+/-) %
TokenBridge::exit_to_l1_public 6,463 (+124) +1.96%
Lending::withdraw_public 1,907 (+4) +0.21%
Lending::borrow_public 1,907 (+4) +0.21%
FPC::prepare_fee 1,999 (+4) +0.20%
FPC::pay_refund 2,054 (+4) +0.20%
StaticParent::public_nested_static_call 2,059 (+4) +0.19%
Parent::public_static_call 1,138 (-4) -0.35%
StaticParent::public_static_call 1,138 (-4) -0.35%
ImportTest::public_dispatch 1,061 (-4) -0.38%
AvmTest::u128_from_integer_overflow 813 (-4) -0.49%
Uniswap::_assert_token_is_same 717 (-4) -0.55%
AvmTest::u128_addition_overflow 1,329 (-8) -0.60%
DocsExample::get_public_immutable_constrained_public_indirect 656 (-4) -0.61%
AuthWitTest::consume_public 622 (-4) -0.64%
Child::set_value_twice_with_nested_last 589 (-4) -0.67%
Child::set_value_twice_with_nested_first 589 (-4) -0.67%
Parent::pub_entry_point 578 (-4) -0.69%
StaticParent::public_call 578 (-4) -0.69%
AvmTest::nested_static_call_to_add 569 (-4) -0.70%
AvmTest::nested_call_to_add 569 (-4) -0.70%
AvmTest::nested_call_to_assert_same 569 (-4) -0.70%
AvmTest::keccak_hash 2,381 (-17) -0.71%
StaticParent::public_get_value_from_child 555 (-4) -0.72%
AvmTest::nested_call_to_add_with_gas 544 (-4) -0.73%
AvmTest::emit_unencrypted_log 2,756 (-21) -0.76%
AvmTest::create_different_nullifier_in_nested_call 494 (-4) -0.80%
Router::_check_timestamp 985 (-8) -0.81%
AvmTest::create_same_nullifier_in_nested_call 484 (-4) -0.82%
Router::_check_block_number 968 (-8) -0.82%
ImportTest::pub_call_public_fn 479 (-4) -0.83%
AvmTest::nested_static_call_to_set_storage 478 (-4) -0.83%
Child::set_value_with_two_nested_calls 930 (-8) -0.85%
AvmTest::nested_call_to_nothing 464 (-4) -0.85%
AvmTest::external_call_to_assertion_failure 464 (-4) -0.85%
AvmTest::external_call_to_divide_by_zero 464 (-4) -0.85%
Test::emit_unencrypted 1,471 (-13) -0.88%
NFT::_store_payload_in_transient_storage_unsafe 1,172 (-13) -1.10%
Token::_store_payload_in_transient_storage_unsafe 1,172 (-13) -1.10%
TestLog::emit_unencrypted_events 1,136 (-13) -1.13%
TokenBlacklist::constructor 6,163 (-79) -1.27%
Parent::pub_entry_point_twice 975 (-13) -1.32%
CardGame::on_cards_claimed 7,195 (-108) -1.48%
Auth::set_authorized_delay 4,576 (-69) -1.49%
Auth::set_authorized 4,480 (-74) -1.62%
Lending::_withdraw 8,523 (-141) -1.63%
StaticParent::public_dispatch 5,687 (-98) -1.69%
Lending::update_accumulator 5,665 (-99) -1.72%
AvmTest::sha256_hash 3,855 (-68) -1.73%
Token::constructor 4,057 (-73) -1.77%
NFT::constructor 3,982 (-73) -1.80%
TokenBlacklist::mint_private 3,673 (-69) -1.84%
Lending::_borrow 7,268 (-149) -2.01%
TokenBlacklist::update_roles 6,022 (-125) -2.03%
Uniswap::swap_public 14,952 (-318) -2.08%
CardGame::on_game_joined 4,976 (-110) -2.16%
Lending::deposit_public 2,555 (-57) -2.18%
TokenBlacklist::shield 5,681 (-127) -2.19%
Uniswap::_approve_bridge_and_exit_input_asset_to_L1 6,087 (-137) -2.20%
AppSubscription::constructor 2,770 (-64) -2.26%
TokenBlacklist::transfer_public 5,493 (-127) -2.26%
Lending::repay_public 2,438 (-57) -2.28%
NFT::transfer_in_public 3,263 (-77) -2.31%
AuthWitTest::public_dispatch 1,624 (-39) -2.35%
Crowdfunding::init 2,652 (-64) -2.36%
Auth::public_dispatch 8,591 (-209) -2.38%
TokenBlacklist::burn_public 5,113 (-127) -2.42%
StatefulTest::public_constructor 2,723 (-68) -2.44%
AppSubscription::public_dispatch 3,896 (-99) -2.48%
Lending::_repay 5,547 (-141) -2.48%
TokenBlacklist::get_roles 2,618 (-69) -2.57%
AvmTest::bulk_testing 22,471 (-603) -2.61%
Auth::constructor 2,342 (-64) -2.66%
EasyPrivateVoting::constructor 2,338 (-64) -2.66%
Uniswap::constructor 2,301 (-64) -2.71%
Crowdfunding::_publish_donation_receipts 927 (-26) -2.73%
Uniswap::public_dispatch 22,496 (-640) -2.77%
Lending::init 2,876 (-82) -2.77%
InclusionProofs::constructor 2,237 (-64) -2.78%
AvmInitializerTest::public_dispatch 2,633 (-77) -2.84%
TokenBlacklist::mint_public 3,886 (-115) -2.87%
Test::consume_message_from_arbitrary_sender_public 7,703 (-228) -2.87%
Token::transfer_in_public 4,107 (-123) -2.91%
Token::burn_public 4,057 (-123) -2.94%
TokenBlacklist::public_dispatch 22,514 (-699) -3.01%
Token::complete_refund 5,326 (-166) -3.02%
Parent::public_dispatch 7,479 (-244) -3.16%
AvmTest::public_dispatch 58,661 (-2,110) -3.47%
TokenBridge::claim_public 10,981 (-401) -3.52%
AuthRegistry::public_dispatch 7,660 (-283) -3.56%
Lending::_deposit 2,459 (-91) -3.57%
Router::public_dispatch 2,275 (-86) -3.64%
Test::consume_mint_to_public_message 10,487 (-397) -3.65%
Claim::constructor 2,363 (-90) -3.67%
FeeJuice::check_balance 2,145 (-82) -3.68%
FeeJuice::_increase_public_balance 2,142 (-82) -3.69%
Token::public_dispatch 30,460 (-1,174) -3.71%
Lending::get_asset 2,123 (-82) -3.72%
PriceFeed::public_dispatch 2,982 (-116) -3.74%
AuthRegistry::consume 2,824 (-110) -3.75%
Auth::get_authorized_delay 1,974 (-77) -3.75%
Claim::public_dispatch 3,128 (-124) -3.81%
TokenBridge::constructor 2,267 (-90) -3.82%
FPC::constructor 2,228 (-90) -3.88%
AvmInitializerTest::constructor 1,875 (-77) -3.94%
EasyPrivateVoting::add_to_tally_public 1,976 (-82) -3.98%
Auth::get_authorized 1,836 (-77) -4.03%
Crowdfunding::public_dispatch 4,485 (-189) -4.04%
Auth::get_scheduled_authorized 1,736 (-77) -4.25%
AvmTest::get_args_hash 1,727 (-77) -4.27%
Spam::public_dispatch 3,110 (-139) -4.28%
AuthRegistry::is_consumable 1,831 (-82) -4.29%
AuthRegistry::_set_authorized 1,824 (-82) -4.30%
AvmTest::add_storage_map 1,824 (-82) -4.30%
TokenBlacklist::balance_of_public 1,822 (-82) -4.31%
Token::balance_of_public 1,822 (-82) -4.31%
Spam::public_spam 2,329 (-105) -4.31%
StatefulTest::public_dispatch 5,875 (-266) -4.33%
TokenBridge::public_dispatch 19,839 (-901) -4.34%
Token::_finalize_transfer_to_private_unsafe 6,392 (-294) -4.40%
AuthRegistry::set_authorized 1,777 (-82) -4.41%
Token::finalize_transfer_to_private 6,345 (-294) -4.43%
FeeJuice::balance_of_public 1,768 (-82) -4.43%
Test::public_dispatch 18,294 (-853) -4.46%
Token::mint_to_public 2,740 (-128) -4.46%
Parent::public_nested_static_call 3,279 (-154) -4.49%
CardGame::on_card_played 5,730 (-270) -4.50%
Lending::get_position 4,783 (-226) -4.51%
PriceFeed::set_price 1,728 (-82) -4.53%
NFT::set_minter 1,727 (-82) -4.53%
Token::set_minter 1,727 (-82) -4.53%
NFT::is_minter 1,724 (-82) -4.54%
Token::is_minter 1,724 (-82) -4.54%
AvmTest::set_storage_map 1,722 (-82) -4.55%
Benchmarking::increment_balance 2,281 (-109) -4.56%
NFT::_finish_transfer_to_public 1,709 (-82) -4.58%
Benchmarking::broadcast 1,698 (-82) -4.61%
PriceFeed::get_price 1,676 (-82) -4.66%
StatefulTest::increment_public_value 1,674 (-82) -4.67%
AuthRegistry::is_reject_all 1,670 (-82) -4.68%
StatefulTest::get_public_value 1,660 (-82) -4.71%
Token::_finalize_mint_to_private_unsafe 6,031 (-298) -4.71%
AvmTest::poseidon2_hash 1,652 (-82) -4.73%
Token::finalize_mint_to_private 5,984 (-298) -4.74%
AvmTest::read_storage_map 1,629 (-82) -4.79%
AuthRegistry::set_reject_all 1,625 (-82) -4.80%
StatefulTest::increment_public_value_no_init_check 1,625 (-82) -4.80%
TestLog::public_dispatch 2,260 (-119) -5.00%
FeeJuice::public_dispatch 5,026 (-266) -5.03%
NFT::public_dispatch 22,620 (-1,200) -5.04%
Lending::public_dispatch 25,971 (-1,379) -5.04%
Child::public_dispatch 4,532 (-242) -5.07%
TokenBlacklist::_increase_public_balance 2,365 (-128) -5.13%
Token::_increase_public_balance 2,365 (-128) -5.13%
NFT::_finalize_transfer_to_private_unsafe 5,343 (-298) -5.28%
NFT::mint 2,694 (-151) -5.31%
NFT::finalize_transfer_to_private 5,296 (-298) -5.33%
CardGame::public_dispatch 15,310 (-886) -5.47%
FPC::public_dispatch 6,850 (-408) -5.62%
InclusionProofs::public_dispatch 3,550 (-212) -5.64%
CardGame::start_game 6,745 (-420) -5.86%
StaticChild::public_dispatch 1,988 (-124) -5.87%
AvmTest::returndata_copy_oracle 1,722 (-111) -6.06%
NFT::owner_of 2,283 (-151) -6.20%
Benchmarking::public_dispatch 3,681 (-291) -7.33%
DocsExample::public_dispatch 3,890 (-350) -8.25%
EasyPrivateVoting::public_dispatch 4,681 (-523) -10.05%
Lending::get_assets 432 (-86) -16.60%

Copy link
Contributor

github-actions bot commented Nov 27, 2024

Changes to circuit sizes

Generated at commit: 1902254d9bf56e78f911feeb5cd51b04dffcd0df, compared to commit: b5a6aa4ce51a27b220162d48ba065a0077b9fcd8

🧾 Summary (100% most significant diffs)

Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_private +1,058,769 ❌ +625.85% +2,611,304 ❌ +99.77%
rollup_base_public +1,135,701 ❌ +319.31% +2,732,840 ❌ +70.65%
private_kernel_reset +31,516 ❌ +35.15% +48,210 ❌ +7.56%
private_kernel_tail_to_public -558 ✅ -3.66% +1,218 ❌ +4.60%
private_kernel_reset_4_4_4_4_4_4_4_4_1 +5,918 ❌ +15.95% +4,802 ❌ +4.54%
private_kernel_init -119 ✅ -0.58% +657 ❌ +1.96%
private_kernel_inner -150 ✅ -0.41% +652 ❌ +1.17%
rollup_root +1,937 ❌ +16.80% +1,947 ❌ +0.10%
rollup_block_merge +1,937 ❌ +16.78% +1,947 ❌ +0.10%
parity_root -198 ✅ -4.14% -198 ✅ -0.01%
rollup_merge -132 ✅ -4.06% -132 ✅ -0.01%
rollup_block_root -262 ✅ -6.06% -280 ✅ -0.01%
parity_base -198 ✅ -4.89% -198 ✅ -0.65%

Full diff report 👇
Program ACIR opcodes (+/-) % Circuit size (+/-) %
rollup_base_private 1,227,943 (+1,058,769) +625.85% 5,228,613 (+2,611,304) +99.77%
rollup_base_public 1,491,375 (+1,135,701) +319.31% 6,600,777 (+2,732,840) +70.65%
private_kernel_reset 121,178 (+31,516) +35.15% 685,689 (+48,210) +7.56%
private_kernel_tail_to_public 14,695 (-558) -3.66% 27,679 (+1,218) +4.60%
private_kernel_reset_4_4_4_4_4_4_4_4_1 43,024 (+5,918) +15.95% 110,532 (+4,802) +4.54%
private_kernel_init 20,549 (-119) -0.58% 34,177 (+657) +1.96%
private_kernel_inner 36,617 (-150) -0.41% 56,500 (+652) +1.17%
rollup_root 13,465 (+1,937) +16.80% 1,860,006 (+1,947) +0.10%
rollup_block_merge 13,481 (+1,937) +16.78% 1,860,020 (+1,947) +0.10%
parity_root 4,584 (-198) -4.14% 3,636,338 (-198) -0.01%
rollup_merge 3,120 (-132) -4.06% 1,826,783 (-132) -0.01%
rollup_block_root 4,060 (-262) -6.06% 2,739,241 (-280) -0.01%
parity_base 3,851 (-198) -4.89% 30,284 (-198) -0.65%

AztecBot and others added 12 commits November 28, 2024 08:02
…ang/noir#6615)

chore: improve error message of `&T` (noir-lang/noir#6633)
fix: LSP code action wasn't triggering on beginning or end of identifier (noir-lang/noir#6616)
chore!: remove `ec` module from stdlib (noir-lang/noir#6612)
fix(LSP): use generic self type to narrow down methods to complete (noir-lang/noir#6617)
fix!: Disallow `#[export]` on associated methods (noir-lang/noir#6626)
chore: redo typo PR by donatik27 (noir-lang/noir#6575)
chore: redo typo PR by Dimitrolito (noir-lang/noir#6614)
feat: simplify `jmpif`s by reversing branches if condition is negated (noir-lang/noir#5891)
fix: Do not warn on unused functions marked with #[export] (noir-lang/noir#6625)
chore: Add panic for compiler error described in #6620 (noir-lang/noir#6621)
feat(perf): Track last loads per block in mem2reg and remove them if possible (noir-lang/noir#6088)
fix(ssa): Track all local allocations during flattening (noir-lang/noir#6619)
feat(comptime): Implement blackbox functions in comptime interpreter (noir-lang/noir#6551)
chore: derive PartialEq and Hash for FieldElement (noir-lang/noir#6610)
chore: ignore almost-empty directories in nargo_cli tests (noir-lang/noir#6611)
chore: remove temporary allocations from `num_bits` (noir-lang/noir#6600)
chore: Release Noir(1.0.0-beta.0) (noir-lang/noir#6562)
feat: Add `array_refcount` and `slice_refcount` builtins for debugging (noir-lang/noir#6584)
chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
chore: improve error message of `&T` (noir-lang/noir#6633)
fix: LSP code action wasn't triggering on beginning or end of identifier (noir-lang/noir#6616)
chore!: remove `ec` module from stdlib (noir-lang/noir#6612)
fix(LSP): use generic self type to narrow down methods to complete (noir-lang/noir#6617)
fix!: Disallow `#[export]` on associated methods (noir-lang/noir#6626)
chore: redo typo PR by donatik27 (noir-lang/noir#6575)
chore: redo typo PR by Dimitrolito (noir-lang/noir#6614)
feat: simplify `jmpif`s by reversing branches if condition is negated (noir-lang/noir#5891)
fix: Do not warn on unused functions marked with #[export] (noir-lang/noir#6625)
chore: Add panic for compiler error described in #6620 (noir-lang/noir#6621)
feat(perf): Track last loads per block in mem2reg and remove them if possible (noir-lang/noir#6088)
fix(ssa): Track all local allocations during flattening (noir-lang/noir#6619)
feat(comptime): Implement blackbox functions in comptime interpreter (noir-lang/noir#6551)
chore: derive PartialEq and Hash for FieldElement (noir-lang/noir#6610)
chore: ignore almost-empty directories in nargo_cli tests (noir-lang/noir#6611)
chore: remove temporary allocations from `num_bits` (noir-lang/noir#6600)
chore: Release Noir(1.0.0-beta.0) (noir-lang/noir#6562)
feat: Add `array_refcount` and `slice_refcount` builtins for debugging (noir-lang/noir#6584)
chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
feat(ssa): Deduplicate intrinsics with predicates (noir-lang/noir#6615)
chore: improve error message of `&T` (noir-lang/noir#6633)
fix: LSP code action wasn't triggering on beginning or end of identifier (noir-lang/noir#6616)
chore!: remove `ec` module from stdlib (noir-lang/noir#6612)
fix(LSP): use generic self type to narrow down methods to complete (noir-lang/noir#6617)
fix!: Disallow `#[export]` on associated methods (noir-lang/noir#6626)
chore: redo typo PR by donatik27 (noir-lang/noir#6575)
chore: redo typo PR by Dimitrolito (noir-lang/noir#6614)
feat: simplify `jmpif`s by reversing branches if condition is negated (noir-lang/noir#5891)
fix: Do not warn on unused functions marked with #[export] (noir-lang/noir#6625)
chore: Add panic for compiler error described in #6620 (noir-lang/noir#6621)
feat(perf): Track last loads per block in mem2reg and remove them if possible (noir-lang/noir#6088)
fix(ssa): Track all local allocations during flattening (noir-lang/noir#6619)
feat(comptime): Implement blackbox functions in comptime interpreter (noir-lang/noir#6551)
chore: derive PartialEq and Hash for FieldElement (noir-lang/noir#6610)
chore: ignore almost-empty directories in nargo_cli tests (noir-lang/noir#6611)
chore: remove temporary allocations from `num_bits` (noir-lang/noir#6600)
chore: Release Noir(1.0.0-beta.0) (noir-lang/noir#6562)
feat: Add `array_refcount` and `slice_refcount` builtins for debugging (noir-lang/noir#6584)
chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
feat(ssa): Deduplicate intrinsics with predicates (noir-lang/noir#6615)
chore: improve error message of `&T` (noir-lang/noir#6633)
fix: LSP code action wasn't triggering on beginning or end of identifier (noir-lang/noir#6616)
chore!: remove `ec` module from stdlib (noir-lang/noir#6612)
fix(LSP): use generic self type to narrow down methods to complete (noir-lang/noir#6617)
fix!: Disallow `#[export]` on associated methods (noir-lang/noir#6626)
chore: redo typo PR by donatik27 (noir-lang/noir#6575)
chore: redo typo PR by Dimitrolito (noir-lang/noir#6614)
feat: simplify `jmpif`s by reversing branches if condition is negated (noir-lang/noir#5891)
fix: Do not warn on unused functions marked with #[export] (noir-lang/noir#6625)
chore: Add panic for compiler error described in #6620 (noir-lang/noir#6621)
feat(perf): Track last loads per block in mem2reg and remove them if possible (noir-lang/noir#6088)
fix(ssa): Track all local allocations during flattening (noir-lang/noir#6619)
feat(comptime): Implement blackbox functions in comptime interpreter (noir-lang/noir#6551)
chore: derive PartialEq and Hash for FieldElement (noir-lang/noir#6610)
chore: ignore almost-empty directories in nargo_cli tests (noir-lang/noir#6611)
chore: remove temporary allocations from `num_bits` (noir-lang/noir#6600)
chore: Release Noir(1.0.0-beta.0) (noir-lang/noir#6562)
feat: Add `array_refcount` and `slice_refcount` builtins for debugging (noir-lang/noir#6584)
chore!: Require types of globals to be specified (noir-lang/noir#6592)
fix: don't report visibility errors when elaborating comptime value (noir-lang/noir#6498)
fix: preserve newlines between comments when formatting statements (noir-lang/noir#6601)
fix: parse a bit more SSA stuff (noir-lang/noir#6599)
chore!: remove eddsa from stdlib (noir-lang/noir#6591)
chore: Typo in oracles how to (noir-lang/noir#6598)
feat(ssa): Loop invariant code motion (noir-lang/noir#6563)
fix: remove `compiler_version` from new `Nargo.toml` (noir-lang/noir#6590)
feat: Avoid incrementing reference counts in some cases (noir-lang/noir#6568)
chore: fix typo in test name (noir-lang/noir#6589)
fix: consider prereleases to be compatible with pre-1.0.0 releases (noir-lang/noir#6580)
feat: try to inline brillig calls with all constant arguments  (noir-lang/noir#6548)
fix: correct type when simplifying `derive_pedersen_generators` (noir-lang/noir#6579)
feat: Sync from aztec-packages (noir-lang/noir#6576)
@TomAFrench
Copy link
Member

@asterite can you look into why we're getting a test failure in load_aliases_in_predecessor_block while this passes in the main repo?

Comment on lines 453 to 459
// FIXME: This causes errors in the sha256 tests
//
// If there was another store to this instruction without any (unremoved) loads or
// function calls in-between, we can remove the previous store.
if let Some(last_store) = references.last_stores.get(&address) {
self.instructions_to_remove.insert(*last_store);
}
// if let Some(last_store) = references.last_stores.get(&address) {
// self.instructions_to_remove.insert(*last_store);
// }
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@TomAFrench In Noir master this commented code is actually uncommented. Uncommenting it makes the test pass, though I don't know if it was commented on Aztec-Packages's side...

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Not sure why this is commented here. Most likely a dodgy conflict resolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants