Conversation
Change needed in case of plugins that inherit from other plugins. The parent class would be registered once more after the plugin, basically cancelling the registration of the desired plugin.
|
I see that some tests fail. Maybe I am missing something.. |
|
Seems like this "feature" was utilized in straxen in the past, so probably in other places too. Actually, in straxen we were particularly lazy as we register_all Maybe instead for now you could add a warning that these additional plugins will not be registered anymore in a feature release unless explicitly imported? Or you could add a "strict/sloppy" argument for register all if yo want to be able to turn on/off this behavior. Otherwise things start breaking all at once (as you see with these tests now). |
If you do register_all on a module that contains a plugin that inherits with another, the effect of registering the plugin will be cancelled.
Example:
Module1:
Module 2:
Running register_all on Module2 will register:
Adding this check, this will only register MyPlugin.