Draft
Conversation
merge upstream changes
merge upstream
merge upstream changes
merge upstream changes
…ract_processor
… into absract_processor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the problem / what does the code in this PR do
Strax is currently designed to use the ThreadedMailboxProcessor exclusively for processing. This PR is the first step needed to allow for run-time processor selection.
Can you briefly describe how it works?
Code was reorganized to allow for multiple processor classes. Processor selection can be done by passing the name of a known processor or by passing in a class that implements an iter() method. We might want to further restrict this in the future to only allow sub-classes of BaseProcessor but for now only the iter method is called so no reason not to allow duck-typing.
Can you give a minimal working example (or illustrate with a figure)?
st.get_array(processor="processor_name")should work when multiple processors are implemented. Defaults to current implementation.