Skip to content

1280 ip approval tool double char limit for description #205

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
jerricotandelacruz merged 3 commits into from
Apr 8, 2025
Merged

1280 ip approval tool double char limit for description #205

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
d6245e3
increase char count of description and reason
iibuan Apr 8, 2025
be2849e
increase char count to a thousand
iibuan Apr 8, 2025
37f72f3
Update field names on email
iibuan Apr 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions src/goapp/controller/ip-disclosure/ip-disclosure-controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,15 +145,15 @@ func (c *ipDisclosureController) InsertIPDisclosureRequest(w http.ResponseWriter
</tr>
<tr class="border-top">
<td style="font-size: 14px; padding-top: 15px; font-weight: 600;">
Intellectual Property Title
Title
</td>
<td style="font-size: 14px; padding-top: 15px; font-weight: 400;">
|IPTitle|
</td>
</tr>
<tr class="border-top">
<td style="font-size: 14px; padding-top: 15px; font-weight: 600;">
Intellectual Property Type
Type
</td>
<td style="font-size: 14px; padding-top: 15px; font-weight: 400;">
|IPType|
Expand Down
4 changes: 2 additions & 2 deletions src/goapp/templates/ipdisclosurerequest.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,7 @@ <h3 class="block text-base font-bold text-gray-700">Intellectual Property Inform
</div>
<div class="mt-1">
<p class="text-sm font-semibold text-gray-700">Description</p>
<textarea name="description" id="description" rows="3" maxlength="350" x-model="form.description"
<textarea name="description" id="description" rows="3" maxlength="1000" x-model="form.description"
class="mt-1 focus:ring-orange-500 focus:border-orange-500 block w-full shadow-sm sm:text-sm border-gray-300 rounded-md border-1 w-4/5 min-w-[480px]">
</textarea>
</div>
Expand All @@ -58,7 +58,7 @@ <h3 class="block text-base font-bold text-gray-700">Intellectual Property Inform
<div class="mt-4">
<h3 class="block text-base font-bold text-gray-700">Reason</h3>
<div class="mx-5">
<textarea name="description" id="description" rows="3" maxlength="350" x-model="form.reason"
<textarea name="reason" id="reason" rows="3" maxlength="1000" x-model="form.reason"
class="mt-1 focus:ring-orange-500 focus:border-orange-500 block w-full shadow-sm sm:text-sm border-gray-300 rounded-md border-1 w-4/5 min-w-[480px]">
</textarea>
</div>
Expand Down
4 changes: 2 additions & 2 deletions src/sqldb/Stored Procedures/PR_IPDisclosureRequest_Insert.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,8 @@ CREATE PROCEDURE [dbo].[PR_IPDisclosureRequest_Insert]
@RequestorEmail [VARCHAR](100),
@IPTitle [VARCHAR](100),
@IPType [VARCHAR](100),
@IPDescription [VARCHAR](100),
@Reason [VARCHAR](100)
@IPDescription [VARCHAR](1000),
@Reason [VARCHAR](1000)
AS

DECLARE @ResultTable TABLE(Id [INT]);
Expand Down
4 changes: 2 additions & 2 deletions src/sqldb/Tables/IPDisclosureRequest.sql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,8 +5,8 @@ CREATE TABLE [dbo].[IPDisclosureRequest]
[RequestorEmail] VARCHAR(100) NOT NULL,
[IPTitle] VARCHAR(100) NOT NULL,
[IPType] VARCHAR(100) NOT NULL,
[IPDescription] VARCHAR(100) NOT NULL,
[Reason] VARCHAR(100) NOT NULL,
[IPDescription] VARCHAR(1000) NOT NULL,
[Reason] VARCHAR(1000) NOT NULL,
[ApprovalRequestId] UNIQUEIDENTIFIER NULL,
[IsApproved] BIT NULL,
[ApproverRemarks] VARCHAR(255) NULL,
Expand Down