-
-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SpacingProperty to VirtualizingStackPanel #17356
base: master
Are you sure you want to change the base?
Conversation
You can test this PR using the following package version. |
|
@cla-avalonia agree |
You can test this PR using the following package version. |
…acing and _realizedElements.FirstIndex greater than zero
You can test this PR using the following package version. |
…imateAnchorElementForViewport method
…llowing the example of orientation value
You can test this PR using the following package version. |
Seems to be working now: ControlCatalog.Desktop_KiXoMxkd3k.mp4although there are some TODO’s that require attention: and also the obvious lack of tests (they are only two and they do not check, actually, virtualization), about which I need some third party opinion. |
You can test this PR using the following package version. |
What does the pull request do?
This PR adds SpacingProperty from StackPanel to VirtualizingStackPanel and complements MeasureOverride and ArrangeOverride accordingly
What is the current behavior?
At the moment, VirtualizingStackPanel does not have SpacingProperty and instead you have to use Margin on items and negative Margin in their common container to achieve the same result.
What is the updated/expected behavior with this PR?
Port SpacingProperty from StackPanel to VirtualizingStackPanel taking virtualization into account.
How was the solution implemented (if it's not obvious)?
Checklist
Breaking changes
Fixed issues
Fixes #17336