WIP: PoC cleaning up dashboard redirects.

[markbiek]

Part of #

Proposed Changes

This is experimenting with a more unified way of handling redirects in cases where a user enters the Stepper from either the /ciab or /v2 dashboards and then needs to be redirected back. The goal is to come up with an easy way to handle those redirects that will work regardless of which dashboard the user was on. That way we don't have to worry about /ciab users being redirected to /v2 or vice-versa.

We're adding a new dashboard= query param (currently should only be ciab or v2) in addition to the existing redirect_to param. Those two params together will be used to construct the full url that the user is redirected to.

Testing Instructions

TBD

Pre-merge Checklist

• Has the general commit checklist been followed? (PCYsg-hS-p2)
• Have you written new tests for your changes?
• Have you tested the feature in Simple (P9HQHe-k8-p2), Atomic (P9HQHe-jW-p2), and self-hosted Jetpack sites (PCYsg-g6b-p2)?
• Have you checked for TypeScript, React or other console errors?
• Have you tested accessibility for your changes? Ensure the feature remains usable with various user agents (e.g., browsers), interfaces (e.g., keyboard navigation), and assistive technologies (e.g., screen readers) (PCYsg-S3g-p2).
• Have you used memoizing on expensive computations? More info in Memoizing with create-selector and Using memoizing selectors and Our Approach to Data
• Have we added the "[Status] String Freeze" label as soon as any new strings were ready for translation (p4TIVU-5Jq-p2)?
  • For UI changes, have we tested the change in various languages (for example, ES, PT, FR, or DE)? The length of text and words vary significantly between languages.
• For changes affecting Jetpack: Have we added the "[Status] Needs Privacy Updates" label if this pull request changes what data or activity we track or use (p4TIVU-aUh-p2)?

[github-actions]

Calypso Live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-166933

Jetpack Cloud live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-166933&env=jetpack

Automattic for Agencies live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-166933&env=a8c-for-agencies

Dashboard live (direct link)

https://calypso.live?image=registry.a8c.com/calypso/app:build-166933&env=dashboard

[matticbot]

This PR modifies the release build for the following Calypso Apps:

For info about this notification, see here: PCYsg-OT6-p2

• help-center
• notifications

To test WordPress.com changes, run install-plugin.sh $pluginSlug update/dashboard-redirect-cleanup on your sandbox.

[matticbot]

Here is how your PR affects size of JS and CSS bundles shipped to the user's browser:

App Entrypoints (~6240 bytes added 📈 [gzipped])

Details

name                    parsed_size           gzip_size
entry-login                 +7296 B  (+0.3%)    +3259 B  (+0.5%)
entry-reauth-required       +5071 B  (+0.3%)    +2464 B  (+0.4%)
entry-main                  +5071 B  (+0.2%)    +2459 B  (+0.4%)
entry-stepper               +3919 B  (+0.2%)    +1598 B  (+0.3%)
entry-dashboard-dotcom       +821 B  (+0.0%)     +169 B  (+0.0%)
entry-dashboard-ciab         +821 B  (+0.0%)     +188 B  (+0.0%)
entry-subscriptions           +76 B  (+0.0%)      +40 B  (+0.0%)
entry-domains-landing         +76 B  (+0.0%)      +40 B  (+0.0%)
entry-browsehappy             +76 B  (+0.0%)      +40 B  (+0.1%)

Common code that is always downloaded and parsed every time the app is loaded, no matter which route is used.

Sections (~9123 bytes added 📈 [gzipped])

Details

name                               parsed_size             gzip_size
transferring-hosted-site-flow          +6574 B  (+109.9%)    +1995 B  (+84.5%)
async-step-unified-plans               +5278 B    (+0.4%)    +1459 B   (+0.4%)
woo-hosted-plans                       +5143 B  (+106.9%)    +1580 B  (+86.3%)
async-step-use-my-domain               +5069 B    (+0.2%)    +2373 B   (+0.5%)
plan-upgrade-flow                      +5026 B  (+105.2%)    +1559 B  (+85.6%)
domain-flow                            +4961 B    (+8.6%)    +1431 B   (+7.4%)
sites-dashboard                        -4250 B    (-0.1%)    -1122 B   (-0.1%)
site-settings                          -4250 B    (-0.1%)    -1122 B   (-0.1%)
overview                               -4250 B    (-0.1%)    -1125 B   (-0.1%)
hosting                                -4250 B    (-0.1%)    -1122 B   (-0.1%)
site-performance                       -4176 B    (-0.1%)    -1093 B   (-0.1%)
site-monitoring                        -4176 B    (-0.1%)    -1089 B   (-0.1%)
site-logs                              -4176 B    (-0.1%)    -1090 B   (-0.1%)
github-deployments                     -4176 B    (-0.1%)    -1087 B   (-0.1%)
staging-site                           -4161 B    (-0.1%)    -1084 B   (-0.1%)
plans                                  -4161 B    (-0.1%)    -1084 B   (-0.1%)
domains                                -4161 B    (-0.1%)    -1084 B   (-0.1%)
purchases                              -2469 B    (-0.1%)     -690 B   (-0.1%)
site-blocks                            -2457 B    (-0.5%)     -690 B   (-0.4%)
security                               -2457 B    (-0.3%)     -690 B   (-0.3%)
privacy                                -2457 B    (-0.5%)     -690 B   (-0.4%)
notification-settings                  -2457 B    (-0.3%)     -690 B   (-0.3%)
me                                     -2457 B    (-0.5%)     -690 B   (-0.5%)
developer                              -2457 B    (-0.5%)     -690 B   (-0.4%)
account-close                          -2457 B    (-0.5%)     -690 B   (-0.4%)
account                                -2457 B    (-0.4%)     -690 B   (-0.3%)
oauth2-client                          +2010 B    (+2.8%)     +704 B   (+2.8%)
checkout                               +2010 B    (+0.1%)     +895 B   (+0.1%)
a8c-for-agencies-marketplace           +2010 B    (+0.1%)     +895 B   (+0.1%)
a8c-for-agencies-express-checkout      +2010 B    (+0.1%)     +895 B   (+0.2%)
a8c-for-agencies-client                +2010 B    (+0.1%)     +895 B   (+0.1%)
a8c-for-agencies-reports               -1252 B    (-0.1%)     -327 B   (-0.1%)
a8c-for-agencies-referrals             -1252 B    (-0.1%)     -378 B   (-0.1%)
a8c-for-agencies-sites                 -1239 B    (-0.0%)     -313 B   (-0.0%)
activity                               -1227 B    (-0.2%)     -446 B   (-0.2%)
marketplace                             +771 B    (+0.1%)     +505 B   (+0.2%)
signup                                  +412 B    (+0.1%)      +51 B   (+0.1%)
backup                                  -133 B    (-0.0%)       -9 B   (-0.0%)
performance-profiler                    -121 B    (-0.0%)      -18 B   (-0.0%)

Sections contain code specific for a given set of routes. Is downloaded and parsed only when a particular route is navigated to.

Async-loaded Components (~8526 bytes added 📈 [gzipped])

Details

name                                             parsed_size           gzip_size
async-load-signup-steps-plans-theme-preselected      +6876 B  (+1.3%)    +2297 B  (+1.4%)
async-load-signup-steps-plans                        +6876 B  (+1.3%)    +2289 B  (+1.4%)
async-load-signup-steps-domains                      +4941 B  (+0.2%)    +2245 B  (+0.5%)
async-load-signup-steps-clone-point                  +4878 B  (+3.2%)    +1510 B  (+3.4%)
async-load-signup-steps-user                         +2010 B  (+0.9%)     +704 B  (+1.0%)
async-load-design-blocks                             +2010 B  (+0.1%)     +928 B  (+0.2%)
async-load-v-2-sites-list                              -89 B  (-0.5%)      -28 B  (-0.6%)
async-load-site-change-address-content                 -32 B  (-0.4%)      -11 B  (-0.4%)

React components that are loaded lazily, when a certain part of UI is displayed for the first time.

Legend

What is parsed and gzip size?

Parsed Size: Uncompressed size of the JS and CSS files. This much code needs to be parsed and stored in memory.
Gzip Size: Compressed size of the JS and CSS files. This much data needs to be downloaded over network.

Generated by performance advisor bot at iscalypsofastyet.com.

[fushar]

Apologies if I'm missing something, but wouldn't this be so much simpler if we just modify the existing dashboardLink() / redirectToDashboardLink() to return CIAB URL if we're on CIAB HD?