-
Notifications
You must be signed in to change notification settings - Fork 78
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "visibility" feature #931
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Poked around a bit, had a few thoughts, but the React looks like a seasoned pro!
😍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A couple of questions:
- Is this going to break Outbox pagination? Should we adjust the query there to exclude hidden posts?
- Do we ever even want to save
public
? Should it be more of a defaultnull
case?
|
Updated icons! See: https://mastodon.social/@mattwiebe/113289210941629136 |
@pfefferle I would like to add a feature here: could we add filters, so that other plugins might override the default visibility for a post? Concrete why: some event plugins have a option per event to mark it as "unlisted", which would fit perfectly here. |
@Menrath and @mattwiebe done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Had a run through, the "Public" type is no longer saved, everything looks in order! 🚢
Fix #923
This PR allows users to change the visibility of a post.
Options:
Public
-> defaultQuiet public
-> This behaves exactly like public, except the post will not appear in live feeds or hashtags, explore, or Mastodon search, even if you are opted-in account-wide.Do not federate
-> Do not federate this post.Todo: Use constants