Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reactions: Don't display avatar when it's empty #1103

Merged
merged 6 commits into from
Dec 20, 2024
Merged

Conversation

obenland
Copy link
Member

@obenland obenland commented Dec 19, 2024

Fixes #1101.

Proposed changes:

  • Adds a fallback avatar URL to our default avatar, when there is none defined.

Other information:

  • Have you written new tests for your changes, if applicable?

Testing instructions:

  • Create an actor with an empty avatar.
  • Like a post on your test site.
  • Make sure it's displayed with the default avatar.

After

image

@obenland obenland requested a review from a team December 19, 2024 17:21
@obenland obenland self-assigned this Dec 19, 2024
@github-actions github-actions bot added the [Focus] Editor Changes to the ActivityPub experience in the block editor label Dec 19, 2024
@obenland
Copy link
Member Author

@mattwiebe I didn't expect that running nom run build would result in changes for all blocks. Did I use the wrong command or is that just the way it works?

pfefferle
pfefferle previously approved these changes Dec 20, 2024
@obenland obenland merged commit 345614f into trunk Dec 20, 2024
24 checks passed
@obenland obenland deleted the fix/empty-avatars branch December 20, 2024 14:02
@mattwiebe
Copy link
Contributor

@mattwiebe I didn't expect that running nom run build would result in changes for all blocks. Did I use the wrong command or is that just the way it works?

That's just the way it works, unfortunately.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Focus] Editor Changes to the ActivityPub experience in the block editor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fediverse reactions section - some profile pictures not displayed correctly
3 participants