Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync/private repo #7574

Open
wants to merge 2 commits into
base: trunk
Choose a base branch
from
Open

Sync/private repo #7574

wants to merge 2 commits into from

Conversation

pbking
Copy link
Contributor

@pbking pbking commented Dec 20, 2023

This uses the utility created here to pull changes from the private repository to the public repository.

Copy link
Member

@mikachan mikachan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes look fine apart from the ones for Spiel and Trellick. I'm guessing both these PRs have been merged on GH but not yet pushed to the private repo, so they were reverted with the new utility function.

@@ -7,7 +7,7 @@
* @package trellick
* @since trellick 1.0
*/
declare( strict_types = 1 );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think these changes to Trellick should be kept. They're from this recent PR: #7570

@@ -4,9 +4,7 @@
* Slug: trellick/404
* Inserter: no
*/
declare( strict_types = 1 );
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be kept too.

@@ -1,7 +1,7 @@
=== Trellick ===
Contributors: Automattic
Requires at least: 6.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of these changes should be kept.

@@ -42,7 +42,11 @@ GNU General Public License for more details.

This theme bundles the following third-party resources:

All the images seen on the screenshot.png were generated with AI using Midjourney and DALL-E.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These changes should be kept too, they're from another recent PR: #7554

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants