Skip to content

Minor enhancements for better UI #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Utsav-Ladani wants to merge 3 commits into
base: trunk
Choose a base branch
from
Open

Minor enhancements for better UI #712

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92454ab
Hide label if value is empty
Utsav-Ladani Jan 29, 2026
8f7918b
Allow to fetch all sheet columns instead of just A to Z
Utsav-Ladani Jan 29, 2026
f62f050
Remove escaping to allow usage of SVGs in RDB blocks
Utsav-Ladani Jan 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion inc/Editor/DataBinding/BlockBindings.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -349,7 +349,7 @@ public static function get_value( array $source_args, WP_Block|array $block, str

// Prepend label to value if provided. Class name should match the one
// generated by the block editor script.
if ( ! empty( $field_label ) && 'content' === $attribute_name ) {
if ( ! empty( $field_label ) && 'content' === $attribute_name && ! empty( $value ) ) {
return sprintf( '<span class="rdb-block-label">%s</span> %s', $source_args['label'], $value );
}

Expand Down
2 changes: 1 addition & 1 deletion src/blocks/remote-data-container/render.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@
exit;
}

echo wp_kses_post( BlockBindings::render_remote_data_block( $attributes, $content, $block ) );
echo BlockBindings::render_remote_data_block( $attributes, $content, $block );
2 changes: 1 addition & 1 deletion src/blocks/remote-data-template/render.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,4 +11,4 @@
exit;
}

echo wp_kses_post( BlockBindings::render_remote_data_template_block( $attributes, $content, $block ) );
echo BlockBindings::render_remote_data_template_block( $attributes, $content, $block );
2 changes: 1 addition & 1 deletion src/data-sources/api-clients/google.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ export class GoogleApi {
}

public async getSheetFields( spreadsheetId: string, sheetTitle: string ): Promise< string[] > {
const values = await this.getSheetValues( spreadsheetId, sheetTitle, 'A1:Z1' );
const values = await this.getSheetValues( spreadsheetId, sheetTitle, '1:1' );
if ( ! values?.values?.length ) {
return [];
}
Expand Down