-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add note about git add for rsync tracking #41605
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this in!
I was a bit confused by that monorepo link in the preview:
![image](https://private-user-images.githubusercontent.com/426388/410566556-594e6f51-515a-4f6e-99c5-33f5be6a1ee1.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3MzkyNTg5MDQsIm5iZiI6MTczOTI1ODYwNCwicGF0aCI6Ii80MjYzODgvNDEwNTY2NTU2LTU5NGU2ZjUxLTUxNWEtNGY2ZS05OWM1LTMzZjViZTZhMWVlMS5wbmc_WC1BbXotQWxnb3JpdGhtPUFXUzQtSE1BQy1TSEEyNTYmWC1BbXotQ3JlZGVudGlhbD1BS0lBVkNPRFlMU0E1M1BRSzRaQSUyRjIwMjUwMjExJTJGdXMtZWFzdC0xJTJGczMlMkZhd3M0X3JlcXVlc3QmWC1BbXotRGF0ZT0yMDI1MDIxMVQwNzIzMjRaJlgtQW16LUV4cGlyZXM9MzAwJlgtQW16LVNpZ25hdHVyZT0yMjgwYzdiYjgxOWNhMzExZGE5MTI3MTA5MzI2NDdjMjgyYzA5YjBmMmFiNjk0NzNkMjk0YWUxNmQ1NWRmMWZlJlgtQW16LVNpZ25lZEhlYWRlcnM9aG9zdCJ9.0mKqFwitt7ty9bBIBIGgQan61v3eCuG2_Ig-abA34Dc)
Do you think you could take that opportunity to remove it, and move the link here instead?
Line 3 in 7f07bc7
The `jetpack` CLI tool is used to help with development in [the Jetpack monorepo]. |
Related: #41442 |
@jeherve - I was wondering about that one. Nice catch! I moved the link to where it was intended. |
Proposed changes:
git add
files before rsync will track it.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: