Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a safeguard for Sharing post filter results. #41600

Merged
merged 5 commits into from
Feb 7, 2025
Merged
Show file tree
Hide file tree
Changes from 4 commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/add-sharing-safeguard-post
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: bugfix

Sharing: Fix possible warnings related to plugin compatibility.
Original file line number Diff line number Diff line change
Expand Up @@ -960,7 +960,12 @@
return $text;
}

// We require the post to not be empty and be an actual WordPress post object. If it's not - we just return.
if ( empty( $post ) || ! $post instanceof \WP_Post ) {
return $text;
}

if ( empty( $post ) ) {

Check failure on line 968 in projects/plugins/jetpack/modules/sharedaddy/sharing-service.php

View workflow job for this annotation

GitHub Actions / Static analysis

TypeError PhanImpossibleCondition Impossible attempt to cast $post of type non-empty-mixed to empty FAQ on Phan issues: pdWQjU-Jb-p2
jeherve marked this conversation as resolved.
Show resolved Hide resolved
return $text;
}

Expand Down
Loading