Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a safeguard for Sharing post filter results. #41600

Merged
merged 5 commits into from
Feb 7, 2025
Merged

Add a safeguard for Sharing post filter results. #41600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
dc6e899
Added a safeguard for the post object in Sharing.
zinigor Feb 6, 2025
f615e24
changelog
zinigor Feb 6, 2025
7208205
Merge branch 'trunk' into add/sharing-safeguard-post
zinigor Feb 7, 2025
1e13890
Moved the check upwards and changed it to instance detection, h/t @je…
zinigor Feb 7, 2025
1262c06
Removed accidental duplication.
zinigor Feb 7, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions projects/plugins/jetpack/changelog/add-sharing-safeguard-post
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
Significance: patch
Type: bugfix

Sharing: Fix possible warnings related to plugin compatibility.
3 changes: 2 additions & 1 deletion projects/plugins/jetpack/modules/sharedaddy/sharing-service.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -960,7 +960,8 @@ function sharing_display( $text = '', $echo = false ) {
return $text;
}

if ( empty( $post ) ) {
// We require the post to not be empty and be an actual WordPress post object. If it's not - we just return.
if ( empty( $post ) || ! $post instanceof \WP_Post ) {
return $text;
}

Expand Down
Loading