Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charts: Fix types exports #41562

Merged
merged 4 commits into from
Feb 4, 2025
Merged

Charts: Fix types exports #41562

merged 4 commits into from
Feb 4, 2025

Conversation

kangzj
Copy link
Contributor

@kangzj kangzj commented Feb 4, 2025

Fixes #

Proposed changes:

  • The types declaration in package is not correct
  • Export themes so that consumers could use

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

n/a

Does this pull request change what data or activity we track or use?

no

Testing instructions:

  • Ensure changes look okay
  • cd projects/js-packages/charts && pnpm build:prod
  • Copy js-packages/charts to /path/to/calypso/node_modules/@automattic/charts
  • Navigate to the Calypso repo
  • Run yarn typecheck
  • Ensure no error thrown for the chart lib

@kangzj kangzj added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Team Review labels Feb 4, 2025
@kangzj kangzj requested a review from a team February 4, 2025 21:32
@kangzj kangzj self-assigned this Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

@@ -28,7 +28,7 @@
},
"main": "./dist/cjs/index.js",
"module": "./dist/mjs/index.js",
"types": "./dist/types/index.d.ts",
"types": "./dist/index.d.ts",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

./dist/types/index.d.ts doesn't exist

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Code Coverage Summary

This PR did not change code coverage!

That could be good or bad, depending on the situation. Everything covered before, and still is? Great! Nothing was covered before? Not so great. 🤷

Full summary · JS report

@kangzj kangzj requested a review from annacmc February 4, 2025 21:39
@kangzj kangzj merged commit 3b33cdb into trunk Feb 4, 2025
60 of 61 checks passed
@kangzj kangzj deleted the fix/fix-types-file-charts branch February 4, 2025 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[JS Package] Charts RNA [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant