Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jetpack SEO: fix state effects and suspense prop #41546

Merged
merged 12 commits into from
Feb 4, 2025

Conversation

CGastrell
Copy link
Contributor

Proposed changes:

This PR is yet another rearrange in the code. It addresses internal state inconsistencies derived from managing all the states from hooks. useEffect's are now split to hold better control.
There are a lot of debug calls, trying to understand when timed calls (setTimeout) start to degrade state consistency and when it's React.StrictMode just kicking in.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Does this pull request change what data or activity we track or use?

No

Testing instructions:

We're still behind flags but the assistant should now handle "most" situations. There are still some unexpected behaviors and the completion step still doesn't give you an actual summary of what's done, but the interaction is quite fluent.

Open the editor and use the Jetpack sidebar to trigger the assistant. Follow steps and navigate back and forth, should work fine.

@CGastrell CGastrell added [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it [Status] Ready to Merge Go ahead, you can push that green button! [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Extension] SEO labels Feb 4, 2025
@CGastrell CGastrell requested a review from a team February 4, 2025 14:47
@CGastrell CGastrell self-assigned this Feb 4, 2025
Copy link
Contributor

github-actions bot commented Feb 4, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the change/jetpack-seo-state-effects branch.

  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack change/jetpack-seo-state-effects
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Jetpack plugin:

The Jetpack plugin has different release cadences depending on the platform:

  • WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).
  • WoA releases happen weekly.
  • Releases to self-hosted sites happen monthly. The next release is scheduled for none scheduled (scheduled code freeze on undefined).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Copy link
Contributor

github-actions bot commented Feb 4, 2025

Code Coverage Summary

Coverage changed in 7 files. Only the first 5 are listed here.

File Coverage Δ% Δ Uncovered
projects/plugins/jetpack/extensions/plugins/ai-assistant-plugin/components/seo-assistant/assistant-wizard.tsx 0/86 (0.00%) 0.00% 28 💔
projects/plugins/jetpack/extensions/plugins/ai-assistant-plugin/components/seo-assistant/wizard-step.tsx 0/4 (0.00%) 0.00% 1 💔
projects/plugins/jetpack/extensions/plugins/ai-assistant-plugin/components/seo-assistant/use-completion-step.tsx 0/15 (0.00%) 0.00% -1 💚
projects/plugins/jetpack/extensions/plugins/ai-assistant-plugin/components/seo-assistant/use-keywords-step.tsx 0/25 (0.00%) 0.00% -4 💚
projects/plugins/jetpack/extensions/plugins/ai-assistant-plugin/components/seo-assistant/wizard-messages.tsx 0/26 (0.00%) 0.00% -5 💚

1 file are newly covered.

File Coverage
projects/plugins/jetpack/extensions/plugins/ai-assistant-plugin/components/seo-assistant/use-welcome-step.tsx 0/2 (0.00%) 💔

Full summary · PHP report · JS report

@CGastrell CGastrell merged commit dba3fb0 into trunk Feb 4, 2025
64 checks passed
@CGastrell CGastrell deleted the change/jetpack-seo-state-effects branch February 4, 2025 15:07
@github-actions github-actions bot added this to the jetpack/14.2.2 milestone Feb 4, 2025
@github-actions github-actions bot removed the [Status] Ready to Merge Go ahead, you can push that green button! label Feb 4, 2025
@tbradsha tbradsha modified the milestones: jetpack/14.2.2, jetpack/14.4 Feb 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Extension] AI Assistant Plugin [Extension] SEO [Plugin] Jetpack Issues about the Jetpack plugin. https://wordpress.org/plugins/jetpack/ [Type] Enhancement Changes to an existing feature — removing, adding, or changing parts of it
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants