-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jetpack SEO: fix state effects and suspense prop #41546
Conversation
…is now a very thin wrapper, we might need to remove it
… add retry handlers, implement global suspense (isBusy)
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Jetpack plugin: The Jetpack plugin has different release cadences depending on the platform:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Code Coverage SummaryCoverage changed in 7 files. Only the first 5 are listed here.
1 file are newly covered.
|
Proposed changes:
This PR is yet another rearrange in the code. It addresses internal state inconsistencies derived from managing all the states from hooks. useEffect's are now split to hold better control.
There are a lot of debug calls, trying to understand when timed calls (
setTimeout
) start to degrade state consistency and when it's React.StrictMode just kicking in.Other information:
Does this pull request change what data or activity we track or use?
No
Testing instructions:
We're still behind flags but the assistant should now handle "most" situations. There are still some unexpected behaviors and the completion step still doesn't give you an actual summary of what's done, but the interaction is quite fluent.
Open the editor and use the Jetpack sidebar to trigger the assistant. Follow steps and navigate back and forth, should work fine.