Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: More handling of no-mirror packages/test-environment #41515

Merged
merged 2 commits into from
Feb 5, 2025

Conversation

anomiex
Copy link
Contributor

@anomiex anomiex commented Feb 3, 2025

Proposed changes:

In release-plugin.sh, don't wait for the package to be published to Packagist since it won't be.

In version-packages.sh, remove the package from require-dev.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • Try it?

In `release-plugin.sh`, don't wait for the package to be published to
Packagist since it won't be.

In `version-packages.sh`, remove the package from `require-dev`.
@anomiex anomiex added [Type] Bug When a feature is broken and / or not performing as intended [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Pri] Normal labels Feb 3, 2025
@anomiex anomiex requested a review from a team February 3, 2025 19:40
@anomiex anomiex self-assigned this Feb 3, 2025
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Copy link
Contributor

@tbradsha tbradsha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change in tools/release-plugin.sh is effectively what I did to bypass this on the fly and makes sense to me.

As for the change in tools/version-packages.sh, I started getting confused when looking:

  • It does appear to remove automattic/jetpack-test-environment in the composer.lock in most places (but not all).
  • It introduces automattic/wordbless. Is that expected?
  • I also notice that a lot of dev dependencies (with mirror repos) remain versioned as @dev. Is that expected?

Finally, would it make sense to just chop dev dependencies altogether in the mirror repos? 🤔

@anomiex
Copy link
Contributor Author

anomiex commented Feb 4, 2025

It introduces automattic/wordbless. Is that expected?

If you're just running the script, it's probably downgrading the packages to the previous release from before test-environment was added. Now that I've done a trunk merge, maybe it's a bit less confusing.

I also notice that a lot of dev dependencies (with mirror repos) remain versioned as @dev. Is that expected?

Where? In the composer.lock? That's probably because it's that way in Packagist. Why that might be I don't know.

Finally, would it make sense to just chop dev dependencies altogether in the mirror repos? 🤔

Maybe.

@anomiex
Copy link
Contributor Author

anomiex commented Feb 4, 2025

Why that might be I don't know.

Ah, the ones that have that going on appear to be the ones using .extra.dependencies.test-only, and it's the test-only dependencies staying at @dev.

@anomiex anomiex merged commit 4c73dcf into trunk Feb 5, 2025
59 checks passed
@anomiex anomiex deleted the update/more-handling-of-no-mirror-packages branch February 5, 2025 15:34
@github-actions github-actions bot removed the [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. label Feb 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
[Pri] Normal [Type] Bug When a feature is broken and / or not performing as intended
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants