-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: More handling of no-mirror packages/test-environment
#41515
Conversation
In `release-plugin.sh`, don't wait for the package to be published to Packagist since it won't be. In `version-packages.sh`, remove the package from `require-dev`.
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The change in tools/release-plugin.sh
is effectively what I did to bypass this on the fly and makes sense to me.
As for the change in tools/version-packages.sh
, I started getting confused when looking:
- It does appear to remove
automattic/jetpack-test-environment
in thecomposer.lock
in most places (but not all). - It introduces
automattic/wordbless
. Is that expected? - I also notice that a lot of dev dependencies (with mirror repos) remain versioned as
@dev
. Is that expected?
Finally, would it make sense to just chop dev dependencies altogether in the mirror repos? 🤔
…-of-no-mirror-packages
If you're just running the script, it's probably downgrading the packages to the previous release from before
Where? In the composer.lock? That's probably because it's that way in Packagist. Why that might be I don't know.
Maybe. |
Ah, the ones that have that going on appear to be the ones using |
Proposed changes:
In
release-plugin.sh
, don't wait for the package to be published to Packagist since it won't be.In
version-packages.sh
, remove the package fromrequire-dev
.Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: