Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DataSync: Cancel all previous mutations upon new mutation of same key #41472

Open
wants to merge 12 commits into
base: trunk
Choose a base branch
from
+36 −15
Open

DataSync: Cancel all previous mutations upon new mutation of same key #41472

Changes from 1 commit
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
d5d1b42
Add React Query devtools
LiamSarsfield Jan 28, 2025
9afd05d
changelog
LiamSarsfield Jan 28, 2025
fbc9d2d
Remove unnecessary argument
LiamSarsfield Jan 28, 2025
203df62
Merge remote-tracking branch 'origin/trunk' into add/react-data-sync-…
LiamSarsfield Jan 29, 2025
5d6a5d3
Re-add line that was unnecessarily removed
LiamSarsfield Jan 29, 2025
7215b31
Cancel all previous mutations upon new mutation of same key
LiamSarsfield Jan 31, 2025
9b8ef9d
Merge branch 'trunk' into fix/react-data-sync-client/boost-settings-r…
LiamSarsfield Jan 31, 2025
75fd196
Refine how abortControllers are fetched
LiamSarsfield Jan 31, 2025
8ef7f3f
Merge branch 'fix/react-data-sync-client/boost-settings-racing-condit…
LiamSarsfield Jan 31, 2025
528b60d
changelog
LiamSarsfield Jan 31, 2025
88d1c8f
Update handling of abortController state management
LiamSarsfield Feb 4, 2025
16156da
Don't use type casting
dilirity Feb 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions projects/js-packages/react-data-sync-client/src/DataSyncHooks.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,8 +125,13 @@ export function useDataSync<
// AbortController is used to track rapid value mutations
// and will cancel in-flight requests and prevent
// the optimistic value from being reverted.
const getAbortController = () =>
queryClient.getMutationDefaults( queryKey )?.meta?.abortController as AbortController;
const getAbortController = () => {
const defaults = queryClient.getMutationDefaults( queryKey );
return defaults?.meta?.abortController instanceof AbortController
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per discussion with @dilirity, this avoids unnecessary type casts. Thanks for pushing this!

? defaults.meta.abortController
: undefined;
};

const setAbortController = ( abortController: AbortController ) => {
queryClient.setMutationDefaults( queryKey, {
meta: {
Expand All @@ -146,7 +151,7 @@ export function useDataSync<
*/
const mutationConfigDefaults = {
meta: {
abortController: null as AbortController | null,
abortController: null,
},
// Mutation function that's called when the mutation is triggered
mutationFn: value => datasync.SET( value, params, getAbortController()?.signal ),
Expand Down
Loading