-
Notifications
You must be signed in to change notification settings - Fork 808
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MU WPCOM: dashboard: add launchpad #41434
Conversation
Thank you for your PR! When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:
This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖 The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available. Follow this PR Review Process:
Still unsure? Reach out in #jetpack-developers for guidance! Mu Wpcom plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. Wpcomsh plugin:
If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack. |
Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.
Interested in more tips and information?
|
Code Coverage SummaryCoverage changed in 1 file.
|
@@ -73,6 +76,8 @@ | |||
"@wordpress/url": "4.16.0", | |||
"clsx": "2.1.1", | |||
"debug": "4.4.0", | |||
"events": "^3.3.0", | |||
"i18n-calypso": "7.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is probably not a good idea, since i18n of plugins via GlotPress only looks for the functions from @wordpress/i18n
and will ignore calls to i18n-calypso
's translate()
function. Can we avoid bringing in i18n-calypso
?
@@ -48,9 +49,11 @@ | |||
"dependencies": { | |||
"@automattic/calypso-color-schemes": "3.1.3", | |||
"@automattic/color-studio": "4.0.0", | |||
"@automattic/components": "2.2.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This also brings in i18n-calypso
, which may give us trouble with i18n (see the comment below). Are there components in here that we need without equivalents in @wordpress/components
or @automattic/jetpack-components
?
"@automattic/i18n-utils": "1.2.3", | ||
"@automattic/jetpack-base-styles": "workspace:*", | ||
"@automattic/jetpack-shared-extension-utils": "workspace:*", | ||
"@automattic/launchpad": "1.1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here too, whatever is using i18n-calypso
in here is probably not going to be translated properly.
Note
This has been previously merged (#41138), then reverted (#41403) because of a problem with atomic. The problem was addressed in bb324e8.
Note
It's not really +1000 LoC! That's just the package lock file. 😊
See Automattic/wp-calypso#95386.
Proposed changes:
See #39806 for some prior work.
Other information:
Jetpack product discussion
Does this pull request change what data or activity we track or use?
Testing instructions: