Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MU WPCOM: dashboard: add launchpad #41434

Merged
merged 11 commits into from
Jan 30, 2025
Merged

MU WPCOM: dashboard: add launchpad #41434

merged 11 commits into from
Jan 30, 2025

Conversation

ellatrix
Copy link
Contributor

@ellatrix ellatrix commented Jan 30, 2025

Note

This has been previously merged (#41138), then reverted (#41403) because of a problem with atomic. The problem was addressed in bb324e8.

Note

It's not really +1000 LoC! That's just the package lock file. 😊

image image

See Automattic/wp-calypso#95386.

Proposed changes:

  • Add the launchpad component as a widget to the dashboard.
  • Minor adjustments to styling so it fits with wp-admin.

See #39806 for some prior work.

Other information:

  • Have you written new tests for your changes, if applicable?
  • Have you checked the E2E test CI results, and verified that your changes do not break them?
  • Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

  • With classic style admin enabled (Settings > General), create a new (unlaunched) site, and test the links in the Dashboard widget.
  • It should not appear for launched sites.
  • Test the links.
  • Test launching a site (make sure to enable read-write)

Copy link
Contributor

github-actions bot commented Jan 30, 2025

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

  • ✅ Include a description of your PR changes.
  • ✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
  • ✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
  • ✅ Add testing instructions.
  • ✅ Specify whether this PR includes any changes to data or privacy.
  • ✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖


The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.


Follow this PR Review Process:

  1. Ensure all required checks appearing at the bottom of this PR are passing.
  2. Choose a review path based on your changes:
    • A. Team Review: add the "[Status] Needs Team Review" label
      • For most changes, including minor cross-team impacts.
      • Example: Updating a team-specific component or a small change to a shared library.
    • B. Crew Review: add the "[Status] Needs Review" label
      • For significant changes to core functionality.
      • Example: Major updates to a shared library or complex features.
    • C. Both: Start with Team, then request Crew
      • For complex changes or when you need extra confidence.
      • Example: Refactor affecting multiple systems.
  3. Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!


Mu Wpcom plugin:

  • Next scheduled release: WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.


Wpcomsh plugin:

  • Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

@github-actions github-actions bot added the [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! label Jan 30, 2025
Copy link
Contributor

github-actions bot commented Jan 30, 2025

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

  • To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/dashboard-launch-steps branch.

    • For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.
  • To test on Simple, run the following command on your sandbox:

    bin/jetpack-downloader test jetpack add/dashboard-launch-steps
    
    bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/dashboard-launch-steps
    

Interested in more tips and information?

  • In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
  • Read more about our development workflow here: PCYsg-eg0-p2
  • Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

@ellatrix ellatrix added [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Type] Task and removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 30, 2025
Copy link
Contributor

github-actions bot commented Jan 30, 2025

Code Coverage Summary

Coverage changed in 1 file.

File Coverage Δ% Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/features/wpcom-dashboard-widgets/wpcom-dashboard-widgets.php 0/71 (0.00%) 0.00% 17 💔

Full summary · PHP report · JS report

@kraftbj kraftbj added [Status] Ready to Merge Go ahead, you can push that green button! and removed [Status] Needs Review To request a review from fellow Jetpack developers. Label will be renamed soon. [Status] Ready to Merge Go ahead, you can push that green button! labels Jan 30, 2025
@@ -73,6 +76,8 @@
"@wordpress/url": "4.16.0",
"clsx": "2.1.1",
"debug": "4.4.0",
"events": "^3.3.0",
"i18n-calypso": "7.0.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is probably not a good idea, since i18n of plugins via GlotPress only looks for the functions from @wordpress/i18n and will ignore calls to i18n-calypso's translate() function. Can we avoid bringing in i18n-calypso?

@@ -48,9 +49,11 @@
"dependencies": {
"@automattic/calypso-color-schemes": "3.1.3",
"@automattic/color-studio": "4.0.0",
"@automattic/components": "2.2.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This also brings in i18n-calypso, which may give us trouble with i18n (see the comment below). Are there components in here that we need without equivalents in @wordpress/components or @automattic/jetpack-components?

"@automattic/i18n-utils": "1.2.3",
"@automattic/jetpack-base-styles": "workspace:*",
"@automattic/jetpack-shared-extension-utils": "workspace:*",
"@automattic/launchpad": "1.1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here too, whatever is using i18n-calypso in here is probably not going to be translated properly.

@ellatrix ellatrix merged commit 8308501 into trunk Jan 30, 2025
81 of 82 checks passed
@ellatrix ellatrix deleted the add/dashboard-launch-steps branch January 30, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants