Social | Hide irrelevant UI on social admin page #41393

manzoorwanijk · 2025-01-29T12:39:35Z

Proposed changes:

Hide Social Notes if the Social plugin is not active
Hide connection screen and pricing page for WPCOM
Hide upgrade nudge for WPCOM
Add safe fallbacks for settings selectors for WPCOM
Hide shares data on WPCOM
Hide plugin footer on WPCOM
Hide license notice for WPCOM
Hide publicize toggle on WPCOM

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

Add the blog sticker to your site
- wpsh
- add_blog_sticker( 'jetpack-social-admin-page', null, null, blog-id-here );
Activate Social and Deactivate Jetpack
Goto social admin page
Confirm that you see the Social Notes settings
Now deactivate Social and activate Jetpack
Goto Social page again
Confirm that Social Notes is not visible
Goto social admin page for a Simple site
Confirm that all the UIs mentioned to be hidden in "Proposed changes" section are not visible
Toggle ON/OFF UTM settings
Confirm that it works fine
Turn UTM ON/OFF and share a post
Confirm that UTM is attached to the shared post URL

github-actions · 2025-01-29T12:40:28Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the update/social-hide-irrelevant-ui-on-admin-page branch.
- For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack update/social-hide-irrelevant-ui-on-admin-page

bin/jetpack-downloader test jetpack-mu-wpcom-plugin update/social-hide-irrelevant-ui-on-admin-page

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-01-29T12:40:42Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

github-actions · 2025-01-29T13:00:23Z

Code Coverage Summary

Coverage changed in 3 files.

File	Coverage	Δ%	Δ Uncovered
projects/js-packages/publicize-components/src/components/admin-page/support-section/index.js	1/6 (16.67%)	-3.33%	1 💔
projects/js-packages/publicize-components/src/utils/shares-data.ts	0/7 (0.00%)	0.00%	1 💔
projects/js-packages/publicize-components/src/components/admin-page/index.tsx	15/16 (93.75%)	0.89%	0 💚

Full summary · PHP report · JS report

This reverts commit c88feec. Settings API is fixed in #41420

pablinos

I don't think we can get away with not using the is_wpcom checks. I think it might be worth having a utility function for it, rather than always checking the site.host value.

I've adjusted it to use the is_share_limit_enabled for the cards, but that seems a bit unnecessary now if we can't remove the other is_wpcom checks. I suppose the less we have the better?

@gmjuhasz Could you take a look at this please? I think we could probably merge it for the Jetpack release, and improve the WPCOM side of things before we enable it there.

pablinos · 2025-02-02T20:14:02Z

...ckages/publicize-components/src/components/admin-page/toggles/social-module-toggle/index.tsx

+					: __(
+							'Connect your social media accounts and send a post’s featured image and content to the selected channels with a single click when the post is published.',
+							'jetpack-publicize-components'
+					  ) }
 				&nbsp;
 				<ExternalLink href="https://jetpack.com/redirect/?source=social-plugin-publicize-support-admin-page">


We need to update these on WPCOM, or we might be able to handle it via the Jetpack redirect code. I'm not sure if we have the current site type.

projects/js-packages/publicize-components/src/components/admin-page/toggles/styles.module.scss

pablinos · 2025-02-02T20:21:24Z

projects/js-packages/publicize-components/src/components/admin-page/index.tsx

 			<GlobalNotices />
-			{ ( ! hasSocialPaidFeatures() && showPricingPage ) || forceDisplayPricingPage ? (
+			{ ( ! is_wpcom && ! is_woa && ! hasSocialPaidFeatures() && showPricingPage ) ||


I was thinking we probably shouldn't show the pricing page on WoA either. I think we can see the plan there, but it would make for a more consistent experience.

…rrelevant-ui-on-admin-page

projects/js-packages/publicize-components/src/components/admin-page/header/index.js

manzoorwanijk · 2025-02-03T11:25:08Z

...ckages/publicize-components/src/components/admin-page/toggles/social-module-toggle/index.tsx

@@ -92,7 +92,8 @@ const SocialModuleToggle: React.FC = () => {
 				{ ! is_wpcom
 					? __(
 							'When enabled, you’ll be able to connect your social media accounts and send a post’s featured image and content to the selected channels with a single click when the post is published.',
-							'jetpack-publicize-components'
+							'jetpack-publicize-components',
+							/* dummy arg to avoid bad minification */ 0


TS won't be happy with this. A better solution will be to use __ in one string and _x in the other with some optional/empty context.

manzoorwanijk · 2025-02-03T13:07:41Z

projects/js-packages/publicize-components/src/utils/script-data.ts

+ *
+ * @return {boolean} Whether the site host is wpcom.
+ */
+export function isWpcomSite() {


All these utils should ideally goto script-data js package utils, because these are not specific to Social.

But, we should use optional chaining when calling them to avoid Quad Layers plugin mess.

Right, I can move them, this projects/js-packages/publicize-components/src/utils/script-data.ts also sounded like utils for script data tho.

Done in f4d39a6

gmjuhasz

For me this seems to work for me well

gmjuhasz

Now I don't see it on simple sites 🤔 Doing some more testing

Hide Social Notes if Social plugin is not active

2e90863

manzoorwanijk added [Type] Task [Status] Needs Team Review labels Jan 29, 2025

manzoorwanijk self-assigned this Jan 29, 2025

github-actions bot added [Feature] Publicize Now Jetpack Social, auto-sharing [JS Package] Publicize Components [Status] In Progress RNA labels Jan 29, 2025

manzoorwanijk added 2 commits January 29, 2025 18:17

Hide connection screen and pricing page for WPCOM

abfbd5a

Hide upgrade nudge for WPCOM

ccc53f6

manzoorwanijk added 6 commits January 29, 2025 18:30

Add safe fallbacks for settings selectors for WPCOM

d0c1801

Hide shares data on WPCOM

eca5d9e

Hide plugin footer on WPCOM

1980c2a

Hide license notice for WPCOM

f1f7850

Hide publicize toggle on WPCOM

70f0e22

Hide UTM toggle for now on WPCOM

c88feec

manzoorwanijk requested a review from a team January 29, 2025 13:42

manzoorwanijk added 4 commits January 29, 2025 19:18

Merge branch 'trunk' into update/social-hide-irrelevant-ui-on-admin-page

54d6e49

Merge branch 'trunk' into update/social-hide-irrelevant-ui-on-admin-page

f106652

Revert "Hide UTM toggle for now on WPCOM"

50207a9

This reverts commit c88feec. Settings API is fixed in #41420

Merge branch 'trunk' into update/social-hide-irrelevant-ui-on-admin-page

2c324fe

manzoorwanijk marked this pull request as ready for review January 30, 2025 15:57

manzoorwanijk added 2 commits January 31, 2025 09:43

Merge branch 'trunk' into update/social-hide-irrelevant-ui-on-admin-page

bd56a9b

Fix unit tests

05133f4

github-actions bot added the [Tests] Includes Tests label Jan 31, 2025

manzoorwanijk added 2 commits January 31, 2025 14:25

Merge branch 'trunk' into update/social-hide-irrelevant-ui-on-admin-page

e580c5f

Merge branch 'trunk' into update/social-hide-irrelevant-ui-on-admin-page

c126920

manzoorwanijk and others added 2 commits January 31, 2025 18:37

Merge branch 'trunk' into update/social-hide-irrelevant-ui-on-admin-page

45ff34b

Adjust the WPCOM test and display of the toggle section.

bf1f14d

pablinos reviewed Feb 2, 2025

View reviewed changes

pablinos added 2 commits February 2, 2025 20:27

Merge remote-tracking branch 'origin/trunk' into update/social-hide-i…

35ba633

…rrelevant-ui-on-admin-page

Adjust styling and fix selector name.

b244130

manzoorwanijk commented Feb 3, 2025

View reviewed changes

projects/js-packages/publicize-components/src/components/admin-page/header/index.js Show resolved Hide resolved

Add dummy arg to avoid optimisation problems.

0d7f208

manzoorwanijk commented Feb 3, 2025

View reviewed changes

Create our helper function

e0bb04f

manzoorwanijk commented Feb 3, 2025

View reviewed changes

gmjuhasz added 3 commits February 3, 2025 14:14

Hide everything that's not self hosted

76588a3

Move util to script data package

f4d39a6

changelog

ef62856

github-actions bot added the [JS Package] Script Data label Feb 3, 2025

pablinos added this to the jetpack/14.3 milestone Feb 3, 2025

gmjuhasz added 3 commits February 3, 2025 14:51

Clean up function

fa4a2ba

Use function in admin page

abafa4c

Update support doc link and general publicize help link

8bcd8f5

tbradsha removed this from the jetpack/14.3 milestone Feb 3, 2025

pablinos added 2 commits February 3, 2025 19:35

Fix selector to check that the module is active.

ae761c7

Swap to using _x rather than a dummy arg to fix the optimisation

ec669e8

gmjuhasz approved these changes Feb 4, 2025

View reviewed changes

gmjuhasz reviewed Feb 4, 2025

View reviewed changes

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Social | Hide irrelevant UI on social admin page #41393

Social | Hide irrelevant UI on social admin page #41393

manzoorwanijk commented Jan 29, 2025 •

edited

Loading

github-actions bot commented Jan 29, 2025 •

edited

Loading

github-actions bot commented Jan 29, 2025

github-actions bot commented Jan 29, 2025 •

edited

Loading

pablinos left a comment

pablinos Feb 2, 2025

pablinos Feb 2, 2025

manzoorwanijk Feb 3, 2025

manzoorwanijk Feb 3, 2025 •

edited

Loading

gmjuhasz Feb 3, 2025

gmjuhasz Feb 3, 2025

gmjuhasz left a comment

gmjuhasz left a comment

Social | Hide irrelevant UI on social admin page #41393

Are you sure you want to change the base?

Social | Hide irrelevant UI on social admin page #41393

Conversation

manzoorwanijk commented Jan 29, 2025 • edited Loading

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Jan 29, 2025 • edited Loading

github-actions bot commented Jan 29, 2025

github-actions bot commented Jan 29, 2025 • edited Loading

Code Coverage Summary

pablinos left a comment

Choose a reason for hiding this comment

pablinos Feb 2, 2025

Choose a reason for hiding this comment

pablinos Feb 2, 2025

Choose a reason for hiding this comment

manzoorwanijk Feb 3, 2025

Choose a reason for hiding this comment

manzoorwanijk Feb 3, 2025 • edited Loading

Choose a reason for hiding this comment

gmjuhasz Feb 3, 2025

Choose a reason for hiding this comment

gmjuhasz Feb 3, 2025

Choose a reason for hiding this comment

gmjuhasz left a comment

Choose a reason for hiding this comment

gmjuhasz left a comment

Choose a reason for hiding this comment

manzoorwanijk commented Jan 29, 2025 •

edited

Loading

github-actions bot commented Jan 29, 2025 •

edited

Loading

github-actions bot commented Jan 29, 2025 •

edited

Loading

manzoorwanijk Feb 3, 2025 •

edited

Loading