MU WPCOM: dashboard: add daily writing prompt #41094

ellatrix · 2025-01-15T17:30:56Z

See Automattic/wp-calypso#95386.

Proposed changes:

Added a small new widget with the prompt.

Other information:

Have you written new tests for your changes, if applicable?
Have you checked the E2E test CI results, and verified that your changes do not break them?
Have you tested your changes on WordPress.com, if applicable (if so, you'll see a generated comment below with a script to run)?

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

With classic style admin enabled, check the Dashboard and test the widget.

github-actions · 2025-01-15T17:31:53Z

Are you an Automattician? Please test your changes on all WordPress.com environments to help mitigate accidental explosions.

To test on WoA, go to the Plugins menu on a WordPress.com Simple site. Click on the "Upload" button and follow the upgrade flow to be able to upload, install, and activate the Jetpack Beta plugin. Once the plugin is active, go to Jetpack > Jetpack Beta, select your plugin, and enable the add/dashboard-daily-prompt branch.
- For jetpack-mu-wpcom changes, also add define( 'JETPACK_MU_WPCOM_LOAD_VIA_BETA_PLUGIN', true ); to your wp-config.php file.

To test on Simple, run the following command on your sandbox:

bin/jetpack-downloader test jetpack-mu-wpcom-plugin add/dashboard-daily-prompt

Interested in more tips and information?

In your local development environment, use the jetpack rsync command to sync your changes to a WoA dev blog.
Read more about our development workflow here: PCYsg-eg0-p2
Figure out when your changes will be shipped to customers here: PCYsg-eg5-p2

github-actions · 2025-01-15T17:31:57Z

Thank you for your PR!

When contributing to Jetpack, we have a few suggestions that can help us test and review your patch:

✅ Include a description of your PR changes.
✅ Add a "[Status]" label (In Progress, Needs Team Review, ...).
✅ Add a "[Type]" label (Bug, Enhancement, Janitorial, Task).
✅ Add testing instructions.
✅ Specify whether this PR includes any changes to data or privacy.
✅ Add changelog entries to affected projects

This comment will be updated as you work on your PR and make changes. If you think that some of those checks are not needed for your PR, please explain why you think so. Thanks for cooperation 🤖

The e2e test report can be found here. Please note that it can take a few minutes after the e2e tests checks are complete for the report to be available.

Follow this PR Review Process:

Ensure all required checks appearing at the bottom of this PR are passing.
Choose a review path based on your changes:
- A. Team Review: add the "[Status] Needs Team Review" label
  - For most changes, including minor cross-team impacts.
  - Example: Updating a team-specific component or a small change to a shared library.
- B. Crew Review: add the "[Status] Needs Review" label
  - For significant changes to core functionality.
  - Example: Major updates to a shared library or complex features.
- C. Both: Start with Team, then request Crew
  - For complex changes or when you need extra confidence.
  - Example: Refactor affecting multiple systems.
Get at least one approval before merging.

Still unsure? Reach out in #jetpack-developers for guidance!

Mu Wpcom plugin:

Next scheduled release: WordPress.com Simple releases happen semi-continuously (PCYsg-Jjm-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

Wpcomsh plugin:

Next scheduled release: Atomic deploys happen twice daily on weekdays (p9o2xV-2EN-p2).

If you have any questions about the release process, please ask in the #jetpack-releases channel on Slack.

ellatrix · 2025-01-15T17:36:48Z

...s/packages/jetpack-mu-wpcom/src/features/wpcom-dashboard-widgets/wpcom-dashboard-widgets.php

@@ -45,6 +45,8 @@ function () {},
 */
 function enqueue_wpcom_dashboard_widgets() {
 	$handle = jetpack_mu_wpcom_enqueue_assets( 'wpcom-dashboard-widgets', array( 'js', 'css' ) );
+	global $wp_scripts;
+	$wp_scripts->registered[ $handle ]->deps[] = 'gutenberg-wpcom-apifetch';


Unfortunately, we need changes to gutenberg-wpcom too so that the custom middleware is added.

jameskoster · 2025-01-20T14:50:01Z

Some small design feedback on this one;

I think it would be beneficial for the next/previous buttons to be closer to the prompt.
There's room to include next/previous labels to avoid ambiguity (and align with General Tasks).
I think it would be nice to highlight the prompt a little; padding and background color probably adequate.

What do you think?

ellatrix · 2025-01-21T14:45:18Z

I like that! I was trying to make as compact as possible, but this just looks way better!

github-actions · 2025-01-29T16:17:26Z

Code Coverage Summary

Coverage changed in 1 file.

File	Coverage	Δ%	Δ Uncovered
projects/packages/jetpack-mu-wpcom/src/features/wpcom-dashboard-widgets/wpcom-dashboard-widgets.php	0/77 (0.00%)	0.00%	6 💔

Full summary · PHP report · JS report

jameskoster · 2025-01-29T17:07:52Z

Looks good to me! :)

...s/packages/jetpack-mu-wpcom/src/features/wpcom-dashboard-widgets/wpcom-dashboard-widgets.php

youknowriad · 2025-01-31T09:56:23Z

This is testing well for me.

Two remarks:

1- The widget is showing up before the "site" widget, should it show up after that one instead?
2- I understand the need for the gray background behind the subjects (especially because of the next/previous links) but it does feel a bit odd design wise to me, maybe too visible or something. I can't pinpoint exactly how I feel.

youknowriad · 2025-01-31T09:57:58Z

I think what I would prefer design wise, is to remove the gray background and move "next", "previous" next to "view all responses" or alternatively to the top right with a similar link design than "view all responses". Anyway, just random suggestions, no blocker here.

youknowriad · 2025-01-31T10:55:48Z

...es/jetpack-mu-wpcom/src/features/wpcom-dashboard-widgets/wpcom-daily-writing-prompt/index.js

+import { useEffect, useState } from '@wordpress/element';
+import { __ } from '@wordpress/i18n';
+import { addQueryArgs } from '@wordpress/url';
+import moment from 'moment';


Feels too much to import moment for that no? Any alternatives?

Yes, can try to avoid it. Honestly, I just copied it from Calypso :)

youknowriad · 2025-01-31T10:56:25Z

...es/jetpack-mu-wpcom/src/features/wpcom-dashboard-widgets/wpcom-daily-writing-prompt/index.js

+	const [ index, setIndex ] = useState( 0 );
+	useEffect( () => {
+		// See projects/packages/jetpack-mu-wpcom/src/features/wpcom-block-editor-nux/src/blogging-prompts-modal/index.js
+		const path = addQueryArgs( `/wpcom/v3/blogging-prompts`, {


I only tested simple so far, does this work for atomic ...

Also a bit weird that there's no data layer or something, random apiFetch calls scatters like that are hard to evolve and reason about.

I agree, let's polish this once we have most dashboard functionality in.

I only tested simple so far, does this work for atomic ...

Yes, it works on Atomic :)

youknowriad

Other than the position of the widget itself (I prefer under Site) I think this is good to land.

github-actions bot added the [mu wpcom Feature] Wpcom Dashboard Widgets label Jan 15, 2025

github-actions bot added [Package] Jetpack mu wpcom WordPress.com Features [Status] In Progress [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! labels Jan 15, 2025

ellatrix commented Jan 15, 2025

View reviewed changes

github-actions bot added [Plugin] mu wpcom jetpack-mu-wpcom plugin [Plugin] Wpcomsh labels Jan 16, 2025

ellatrix changed the title ~~MU WPCOM: add daily writing prompt to dashboard~~ MU WPCOM: dashboard: add daily writing prompt Jan 16, 2025

ellatrix force-pushed the add/dashboard-daily-prompt branch from 3614768 to bc7c97c Compare January 16, 2025 20:54

ellatrix added the [Type] Task label Jan 16, 2025

ellatrix mentioned this pull request Jan 26, 2025

Untangle My Home Automattic/wp-calypso#95386

Open

ellatrix force-pushed the add/dashboard-daily-prompt branch from bc7c97c to c5a2a2b Compare January 29, 2025 16:08

ellatrix marked this pull request as ready for review January 29, 2025 16:46

ellatrix commented Jan 30, 2025

View reviewed changes

...s/packages/jetpack-mu-wpcom/src/features/wpcom-dashboard-widgets/wpcom-dashboard-widgets.php Outdated Show resolved Hide resolved

ellatrix added 5 commits January 30, 2025 18:39

MU WPCOM: dashboard: add daily writing prompt

7ed8914

Address style feedback

aa81f12

tweak style

b826d28

tweak style

95f6b10

Fix phan

1fdc132

ellatrix force-pushed the add/dashboard-daily-prompt branch from 86fe9f4 to 1fdc132 Compare January 30, 2025 17:43

youknowriad reviewed Jan 31, 2025

View reviewed changes

youknowriad previously approved these changes Jan 31, 2025

View reviewed changes

Remove moment

ee29cf7

ellatrix dismissed youknowriad’s stale review via ee29cf7 January 31, 2025 15:13

ellatrix merged commit dc14f97 into trunk Jan 31, 2025
61 checks passed

ellatrix deleted the add/dashboard-daily-prompt branch January 31, 2025 15:24

github-actions bot removed [Status] Needs Author Reply We would need you to make some changes or provide some more details about your PR. Thank you! [Status] In Progress labels Jan 31, 2025

jboland88 pushed a commit that referenced this pull request Feb 3, 2025

MU WPCOM: dashboard: add daily writing prompt (#41094)

f36ac4c

arthur791004 mentioned this pull request Feb 4, 2025

Port Daily Writing Prompt from My Home as Dashboard widget #39819

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MU WPCOM: dashboard: add daily writing prompt #41094

MU WPCOM: dashboard: add daily writing prompt #41094

ellatrix commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

ellatrix Jan 15, 2025

jameskoster commented Jan 20, 2025

ellatrix commented Jan 21, 2025

github-actions bot commented Jan 29, 2025 •

edited

Loading

jameskoster commented Jan 29, 2025

youknowriad commented Jan 31, 2025

youknowriad commented Jan 31, 2025

youknowriad Jan 31, 2025

ellatrix Jan 31, 2025

youknowriad Jan 31, 2025

youknowriad Jan 31, 2025

ellatrix Jan 31, 2025

ellatrix Jan 31, 2025

youknowriad left a comment

MU WPCOM: dashboard: add daily writing prompt #41094

MU WPCOM: dashboard: add daily writing prompt #41094

Conversation

ellatrix commented Jan 15, 2025 • edited Loading

Proposed changes:

Other information:

Jetpack product discussion

Does this pull request change what data or activity we track or use?

Testing instructions:

github-actions bot commented Jan 15, 2025 • edited Loading

github-actions bot commented Jan 15, 2025 • edited Loading

ellatrix Jan 15, 2025

Choose a reason for hiding this comment

jameskoster commented Jan 20, 2025

ellatrix commented Jan 21, 2025

github-actions bot commented Jan 29, 2025 • edited Loading

Code Coverage Summary

jameskoster commented Jan 29, 2025

youknowriad commented Jan 31, 2025

youknowriad commented Jan 31, 2025

youknowriad Jan 31, 2025

Choose a reason for hiding this comment

ellatrix Jan 31, 2025

Choose a reason for hiding this comment

youknowriad Jan 31, 2025

Choose a reason for hiding this comment

youknowriad Jan 31, 2025

Choose a reason for hiding this comment

ellatrix Jan 31, 2025

Choose a reason for hiding this comment

ellatrix Jan 31, 2025

Choose a reason for hiding this comment

youknowriad left a comment

Choose a reason for hiding this comment

ellatrix commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 15, 2025 •

edited

Loading

github-actions bot commented Jan 29, 2025 •

edited

Loading