Jetpack: optimize the Sharing module hook (#40128)

Make the Sharing module run the `template_redirect` action callback only when necessary.
Automattic · Nov 11, 2024 · 11ca6bd · 11ca6bd
1 parent f609d2d
commit 11ca6bd
Show file tree

Hide file tree

Showing 3 changed files with 14 additions and 2 deletions.
diff --git a/projects/plugins/jetpack/changelog/update-optimize-sharing-hook b/projects/plugins/jetpack/changelog/update-optimize-sharing-hook
@@ -0,0 +1,4 @@
+Significance: patch
+Type: other
+
+Optimize the Sharing module hook callback.
diff --git a/projects/plugins/jetpack/extensions/blocks/sharing-button/sharing-button.php b/projects/plugins/jetpack/extensions/blocks/sharing-button/sharing-button.php
@@ -202,7 +202,11 @@ function sharing_process_requests() {
 		}
 	}
 }
-add_action( 'template_redirect', __NAMESPACE__ . '\sharing_process_requests', 9 );
+
+// phpcs:ignore WordPress.Security.NonceVerification.Recommended -- Only checking for the data being present.
+if ( isset( $_GET['share'] ) ) {
+	add_action( 'template_redirect', __NAMESPACE__ . '\sharing_process_requests', 9 );
+}
 
 /**
  * Automatically add the Sharing Buttons block to the end of the Single Posts template.

diff --git a/projects/plugins/jetpack/modules/sharedaddy/sharing-service.php b/projects/plugins/jetpack/modules/sharedaddy/sharing-service.php
@@ -930,7 +930,11 @@ function sharing_process_requests() {
 		}
 	}
 }
-add_action( 'template_redirect', 'sharing_process_requests', 9 );
+
+// phpcs:ignore WordPress.Security.NonceVerification.Recommended -- Only checking for the data being present.
+if ( isset( $_GET['share'] ) ) {
+	add_action( 'template_redirect', 'sharing_process_requests', 9 );
+}
 
 /**
  * Gets the url to customise the sharing buttons in Calypso.