Media Library: add track events for upload from URL feature (#41620)

Automattic · Feb 7, 2025 · 0831a42 · 0831a42
1 parent 048f9fb
commit 0831a42
Show file tree

Hide file tree

Showing 6 changed files with 25 additions and 18 deletions.
diff --git a/projects/packages/external-media/changelog/media-tracks b/projects/packages/external-media/changelog/media-tracks
@@ -0,0 +1,4 @@
+Significance: patch
+Type: added
+
+Media Library: add track events for upload from URL feature
diff --git a/projects/packages/external-media/src/shared/media-browser/index.js b/projects/packages/external-media/src/shared/media-browser/index.js
@@ -72,8 +72,8 @@ function MediaBrowser( {
 	);
 
 	const onCopyAndInsert = useCallback( () => {
-		tracks.recordEvent( 'jetpack_external_media_modal_cta_click', {
-			page_source: pageSource,
+		tracks.recordEvent( 'jetpack_external_media_modal_submit', {
+			page: pageSource,
 			media_source: mediaSource,
 			media_count: selected.length,
 			multiple: !! multiple,

diff --git a/projects/packages/external-media/src/shared/media-browser/use-page-source.js b/projects/packages/external-media/src/shared/media-browser/use-page-source.js
@@ -1,18 +1,12 @@
 import { useSelect } from '@wordpress/data';
 
 const usePageSource = () => {
-	const isSiteEditor = useSelect( select => !! select( 'core/edit-site' ), [] );
-	const postType = useSelect( select => select( 'core/editor' )?.getCurrentPostType(), [] );
+	const isEditor = useSelect( select => !! select( 'core/editor' ), [] );
 
-	if ( ! postType ) {
-		return 'jetpack-external-media-import-page';
+	if ( isEditor ) {
+		return 'editor';
 	}
-
-	if ( isSiteEditor ) {
-		return 'site-editor';
-	}
-
-	return postType === 'page' ? 'page-editor' : 'post-editor';
+	return 'media-library';
 };
 
 export default usePageSource;
diff --git a/projects/packages/jetpack-mu-wpcom/changelog/media-tracks b/projects/packages/jetpack-mu-wpcom/changelog/media-tracks
@@ -0,0 +1,4 @@
+Significance: patch
+Type: added
+
+Media Library: add track events for upload from URL feature
diff --git a/.../packages/jetpack-mu-wpcom/src/features/wpcom-media/wpcom-media-url-upload-form/index.jsx b/.../packages/jetpack-mu-wpcom/src/features/wpcom-media/wpcom-media-url-upload-form/index.jsx
@@ -1,10 +1,11 @@
 import { __ } from '@wordpress/i18n';
 import clsx from 'clsx';
 import { useState } from 'react';
+import { wpcomTrackEvent } from '../../../common/tracks';
 
 import './style.scss';
 
-const WpcomMediaUrlUploadForm = ( { ajaxUrl, action, nonce, isEditor } ) => {
+const WpcomMediaUrlUploadForm = ( { ajaxUrl, action, nonce, page } ) => {
 	const [ url, setUrl ] = useState( '' );
 
 	const [ show, setShow ] = useState( false );
@@ -25,6 +26,10 @@ const WpcomMediaUrlUploadForm = ( { ajaxUrl, action, nonce, isEditor } ) => {
 		}
 		e.preventDefault();
 
+		wpcomTrackEvent( 'wpcom_media_upload_from_url_submit', {
+			page,
+		} );
+
 		const formData = new FormData();
 		formData.append( 'action', action );
 		formData.append( 'url', url );
@@ -48,7 +53,7 @@ const WpcomMediaUrlUploadForm = ( { ajaxUrl, action, nonce, isEditor } ) => {
 							.collection.add( attachmentToAdd );
 					};
 
-					if ( isEditor ) {
+					if ( page === 'editor' ) {
 						const mediaLibraryTab = window.wp.media.frame.state( 'library' );
 						mediaLibraryTab.trigger( 'open' );
 

diff --git a/projects/packages/jetpack-mu-wpcom/src/features/wpcom-media/wpcom-media-url-upload.php b/projects/packages/jetpack-mu-wpcom/src/features/wpcom-media/wpcom-media-url-upload.php
@@ -23,10 +23,10 @@ function wpcom_media_url_upload() {
 
 	$data = wp_json_encode(
 		array(
-			'ajaxUrl'  => admin_url( 'admin-ajax.php' ),
-			'action'   => 'wpcom_media_url_upload',
-			'nonce'    => wp_create_nonce( 'wpcom_media_url_upload' ),
-			'isEditor' => $pagenow !== 'upload.php',
+			'ajaxUrl' => admin_url( 'admin-ajax.php' ),
+			'action'  => 'wpcom_media_url_upload',
+			'nonce'   => wp_create_nonce( 'wpcom_media_url_upload' ),
+			'page'    => $pagenow === 'upload.php' ? 'media-library' : 'editor',
 		)
 	);