-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(s3stream): add storage status check #1717
base: main
Are you sure you want to change the base?
Conversation
@@ -417,7 +419,7 @@ public CompletableFuture<Void> append(AppendContext context, StreamRecordBatch s | |||
* @return backoff status. | |||
*/ | |||
public boolean append0(AppendContext context, WalWriteRequest request, boolean fromBackoff) { | |||
// TODO: storage status check, fast fail the request when storage closed. | |||
checkStatus(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be #completeException(new IOException())
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should be
#completeException(new IOException())
yes, that would be better
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It should invoke WalWriteRequest.cf#completeException
add storage status check