Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(s3stream): add storage status check #1717

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

CLFutureX
Copy link
Contributor

add storage status check

@CLFutureX CLFutureX changed the title feat(s3stream):add storage status check feat(s3stream): add storage status check Aug 3, 2024
@@ -417,7 +419,7 @@ public CompletableFuture<Void> append(AppendContext context, StreamRecordBatch s
* @return backoff status.
*/
public boolean append0(AppendContext context, WalWriteRequest request, boolean fromBackoff) {
// TODO: storage status check, fast fail the request when storage closed.
checkStatus();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be #completeException(new IOException())

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should be #completeException(new IOException())
yes, that would be better

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should invoke WalWriteRequest.cf#completeException

@CLFutureX CLFutureX requested a review from superhx August 7, 2024 04:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants