Pass headers by reference

Autarkysoft · Sep 18, 2024 · 1fa1ce9 · 1fa1ce9
1 parent e5372df
commit 1fa1ce9
Show file tree

Hide file tree

Showing 3 changed files with 4 additions and 4 deletions.
diff --git a/Src/Autarkysoft.Bitcoin/Blockchain/BlockVerifier.cs b/Src/Autarkysoft.Bitcoin/Blockchain/BlockVerifier.cs
@@ -43,7 +43,7 @@ public BlockVerifier(ITransactionVerifier txVerifier, IConsensus consensus)
 
 
         /// <inheritdoc/>
-        public bool VerifyHeader(BlockHeader header, Target expectedTarget)
+        public bool VerifyHeader(in BlockHeader header, Target expectedTarget)
         {
             Digest256 tar = header.NBits.ToDigest256();
             return header.Version >= consensus.MinBlockVersion &&

diff --git a/Src/Autarkysoft.Bitcoin/Blockchain/Blocks/BlockHeader.cs b/Src/Autarkysoft.Bitcoin/Blockchain/Blocks/BlockHeader.cs
@@ -23,7 +23,7 @@ public readonly struct BlockHeader
         /// <param name="tip">The last valid block in the chain</param>
         /// <param name="merkle">Merkle root hash</param>
         /// <param name="nbits">Block target</param>
-        public BlockHeader(IConsensus consensus, BlockHeader tip, in Digest256 merkle, Target nbits)
+        public BlockHeader(IConsensus consensus, in BlockHeader tip, in Digest256 merkle, Target nbits)
             : this(consensus.MinBlockVersion, tip.Hash, merkle, (uint)UnixTimeStamp.GetEpochUtcNow(), nbits, 0)
         {
         }

diff --git a/Src/Autarkysoft.Bitcoin/Blockchain/IBlockVerifier.cs b/Src/Autarkysoft.Bitcoin/Blockchain/IBlockVerifier.cs
@@ -22,11 +22,11 @@ public interface IBlockVerifier
         /// The target that this header must have (calculated considering difficulty adjustment)
         /// </param>
         /// <returns>True if the given block header was valid; otherwise false.</returns>
-        bool VerifyHeader(BlockHeader header, Target expectedTarget);
+        bool VerifyHeader(in BlockHeader header, Target expectedTarget);
 
         /// <summary>
         /// Verifies validity of the given block. Return value indicates succcess.
-        /// <para/>Header has to be verified before using <see cref="VerifyHeader(BlockHeader, Target)"/> method.
+        /// <para/>Header has to be verified before using <see cref="VerifyHeader(in BlockHeader, Target)"/> method.
         /// <para/><see cref="IConsensus"/> dependency has to be updated by the caller before calling this method.
         /// </summary>
         /// <param name="block">Block to use</param>