More obvious button states

[DJMyles]

Seeks to address #391

Could potentially expand from here but this is is a good start.

I used a negative offset so as to not affect the overall element size as it could affect surrounding elements if used say inline as part of an input group.

Definition of Done

• Content/documentation reviewed by Julian or someone in the Content Team
• UX reviewed by Gary or someone the Design team
• Code reviewed by one of the core developers
• Acceptance Testing
  • Cross-browser tested against standard browser matrix
  • Tested on multiple devices (TBD)
  • HTML5 validation (CircleCI)
  • Accessibility testing & WCAG2 compliance (npm test)
• Stakeholder/PO review
• CHANGELOG updated

[elisechant]

I think this should be visually approved, not just PR'ed.

[klepas]

@elisechant Yup, I want Gary to be across these.

[AndrewArch]

can I suggest that on the 'disabled' button, we use the lightest text colour possible that is still 4.5:1 contrast, eg maybe #404040 or lighter

[gazhands]

Any chance of seeing a live working demo?

[klepas]

@gazhands I’ll deploy one after lunch for you review.

[klepas]

@gazhands here you go: http://dg-uikit-button-offset-hover-proposal.apps.staging.digital.gov.au

[gazhands]

Thanks for the work so far everyone. I feel there's some more iteration on the visual design (of the buttons). Balancing all three states needs to be conceded (hover focus, and active) and getting these right, especially on touch screens.

[klepas]

@gazhands Cool.

I feel there's some more iteration on the visual design (of the buttons). Balancing all three states needs to be conceded (hover focus, and active) and getting these right, especially on touch screens.

Could you elaborate? Does this mean we need to give this to the design clinic?

I’m happy to work any design changes into the 2.x work, so knowing what the go is re. buttons soon would be great. (:

[gazhands]

Don't mind who picks this up but design clinic is a good start. Defo keen to have it for 2.0.

[klepas]

Don't mind who picks this up but design clinic is a good start. Defo keen to have it for 2.0.

*nod*

We will likely look at buttons within the coming two weeks as we write 2.x, so I propose we bring it up tomorrow.