Skip to content

Commit

Permalink
fix
Browse files Browse the repository at this point in the history
  • Loading branch information
AugustinMauroy committed Sep 30, 2023
1 parent e60547a commit cda1903
Show file tree
Hide file tree
Showing 5 changed files with 17 additions and 18 deletions.
2 changes: 1 addition & 1 deletion content/posts/redstonejs.en.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,6 @@ And also respect all the open source best practices.

## Conclusion

I hope you like this project. If you want to help me you can contact me on [twitter](https://twitter.com/AugustinMauroy).
I hope you like this project. If you want to help me you can contact me on [twitter](https://twitter.com/_August1_).

There are still some grey areas in this project, but I think it's a good start. For example, on the subject of dependencies, should we fork them or leave them as they are? I think forking them is the best solution because it gives you better control over the dependencies.
2 changes: 1 addition & 1 deletion content/posts/redstonejs.fr.mdx
Original file line number Diff line number Diff line change
Expand Up @@ -71,6 +71,6 @@ Et aussi repecter toutes les bonne pratique open source.

## Conclusion

Voila, j'espère que ce projet vous plaira. Si vous voulez m'aider vous pouvez me contacter sur [twitter](https://twitter.com/AugustinMauroy).
Voila, j'espère que ce projet vous plaira. Si vous voulez m'aider vous pouvez me contacter sur [twitter](https://twitter.com/_August1_).

Il reste encore des zone d'ombre dans ce projet, mais je pense que c'est un bon début. Par example au sujet des dépendance faut-ils les fork ou les laisser comme elle sont ? Je pense que les fork est la meilleur solution car cela permet d'avoir un meilleur contrôle sur les dépendance.
3 changes: 2 additions & 1 deletion src/components/blog/header/index.module.scss
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,8 @@
line-height: 1.2em;
}

img {
.thumbnail {
border: 1px solid var(--text-color);
border-radius: 10px;
}

Expand Down
15 changes: 7 additions & 8 deletions src/components/blog/header/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,13 @@ const BlogHeader: FC<BlogMetaData> = ({
<AuthorsList authors={authors} />
</div>
{thumbnail && (
<div className={styles.thumbnail}>
<Image
src={`/static/${thumbnail}`}
alt={title}
height={169}
width={300}
/>
</div>
<Image
src={`/static/${thumbnail}`}
alt={title}
height={169}
width={300}
className={styles.thumbnail}
/>
)}
</section>
);
Expand Down
13 changes: 6 additions & 7 deletions src/components/home/findme/index.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -12,16 +12,15 @@ import styles from './index.module.scss';
import type { FC, ReactElement } from 'react';

const iconify = (icon: ReactElement, title: string): ReactElement =>
cloneElement(icon, {
alt: title,
ariaLabel: title,
title,
});

cloneElement(icon, {
alt: title,
ariaLabel: title,
title,
});

const metaData = [
{
icon: <FaGithub/>,
icon: <FaGithub />,
link: 'https://github.com/AugustinMauroy',
title: 'AugustinMauroy',
},
Expand Down

0 comments on commit cda1903

Please sign in to comment.