Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix SE(2) inverse #925

Merged
merged 2 commits into from
Oct 25, 2023
Merged

Fix SE(2) inverse #925

merged 2 commits into from
Oct 25, 2023

Conversation

JeffLIrion
Copy link
Contributor

Reference issue

There's unnecessary brackets: it should be np.cos(self[2]), not np.cos([self[2]]). See JeffLIrion/python-graphslam#31

What does this implement/fix?

Removes the unnecessary brackets.

Additional information

CheckList

  • Did you add an unittest for your new example or defect fix?
  • Did you add documents for your new example?
  • All CIs are green? (You can check it after submitting)

AtsushiSakai
AtsushiSakai approved these changes Oct 25, 2023
View reviewed changes
Copy link
Owner

@AtsushiSakai AtsushiSakai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@AtsushiSakai AtsushiSakai merged commit 3a8d93b into AtsushiSakai:master Oct 25, 2023
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AtsushiSakai AtsushiSakai AtsushiSakai approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JeffLIrion @AtsushiSakai