-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
optimized DStarLite #912
optimized DStarLite #912
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry for late review. PTAL my comments.
@@ -109,41 +123,51 @@ def c(self, node1: Node, node2: Node): | |||
return detected_motion[0].cost | |||
|
|||
def h(self, s: Node): | |||
# Cannot use the 2nd euclidean norm as this might sometimes generate | |||
# heuristics that overestimate the cost, making them inadmissible, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this comments are useful, why did you removed it?
oy.append(i) | ||
for i in range(-10, 40): | ||
ox.append(20.0) | ||
for i in range(0, 20): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why did you changed this?
if show_animation: | ||
plt.plot(ox, oy, ".k") | ||
plt.plot(sx, sy, "og") | ||
plt.plot(gx, gy, "xb") | ||
plt.grid(True) | ||
plt.axis("equal") | ||
label_column = ['Start', 'Goal', 'Path taken', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please explain why did you this changes?
BTW, what part did you “optimized”? |
Reference issue
What does this implement/fix?
Additional information
CheckList