feat: switch to mkdocs-macros #227
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
getting-started
he3als
previously approved these changes
Jul 30, 2024
he3als
previously approved these changes
Jul 30, 2024
|
Where did the atlas version go? |
he3als
approved these changes
Jul 30, 2024
|
Did you test that? It'll be missing the %20s. |
|
Yes |
Yeah it works. lgtm. I can't approve my own PR btw. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type
Questions
Describe your pull request
Switch to
mkdocs-macrosinstead of using a file for variables. Unfortunately macros and variables don't render on pages that the user doesn't see (or maybe just pages loaded viapymdownx.snippets), so MSDL has been moved back toinstallation.md. I don't know a way around this yet.