Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: update troubleshooting, move to atlas config #209

Merged
merged 1 commit into from
Jun 17, 2024

Conversation

he3als
Copy link
Contributor

@he3als he3als commented Jun 16, 2024

Type

  • Rewrite already written documentation
  • Add/remove new pages

Questions

Describe your pull request

Moves the troubleshooting page under Atlas Configuration, where the rest of the folders are. Also updates it for v0.5.0.

https://new-troubleshooting.atlasos-docs-enq.pages.dev/getting-started/post-installation/atlas-folder/troubleshooting/

Copy link

Deploying atlasos-docs with  Cloudflare Pages  Cloudflare Pages

Latest commit: 4a3299c
Status: ✅  Deploy successful!
Preview URL: https://20a263e4.atlasos-docs-enq.pages.dev
Branch Preview URL: https://new-troubleshooting.atlasos-docs-enq.pages.dev

View logs

@he3als he3als requested a review from jacksyrm as a code owner June 16, 2024 17:11
@github-actions github-actions bot added getting-started Issues or PRs related to the 'Getting Started' page mkdocs-config Issues or PRs related to the MkDocs configuration labels Jun 16, 2024
Copy link
Member

@the-P1neapple the-P1neapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make it less confusing for users. Can you add a page in the troubleshooting area to redirect troubleshooting scripts the new location?

@he3als
Copy link
Contributor Author

he3als commented Jun 16, 2024

To make it less confusing for users. Can you add a page in the troubleshooting area to redirect troubleshooting scripts the new location?

There's a link redirect, but I don't think an actual redirect in the sidebar is necessary. It would make sense to look for the 'Troubleshooting' folder under the Atlas folders section.

@the-P1neapple the-P1neapple self-requested a review June 16, 2024 23:20
Copy link
Member

@the-P1neapple the-P1neapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Understandable, all good then.

Copy link
Member

@RadNotRed RadNotRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@he3als he3als merged commit 260b8c3 into v0.5.0 Jun 17, 2024
2 checks passed
@he3als he3als deleted the new-troubleshooting branch June 17, 2024 09:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
getting-started Issues or PRs related to the 'Getting Started' page mkdocs-config Issues or PRs related to the MkDocs configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants