Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Built-in ISO Downloading #113

Merged
merged 3 commits into from
Oct 2, 2023
Merged

Built-in ISO Downloading #113

merged 3 commits into from
Oct 2, 2023

Conversation

he3als
Copy link
Contributor

@he3als he3als commented Oct 1, 2023

Type

  • Rewrite already written documentation.
  • Add/remove new pages.

Questions

Describe your pull request

This integrates Microsoft Software Download Listing into the documentation for ease of access and simplicity. It's basically a fork of the Javascript with many modifications to make it work in the documentation.

iso-download.mp4

@he3als he3als added the bypass Bypass Contribution Guildelines label Oct 1, 2023
@github-actions github-actions bot added getting-started Issues or PRs related to the 'Getting Started' page mkdocs-config Issues or PRs related to the MkDocs configuration labels Oct 1, 2023
Copy link
Member

@Xyueta Xyueta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good job

Copy link
Member

@whallin whallin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

(I'm no one to rate your JS code though)

Copy link
Member

@JayXTQ JayXTQ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice

@Xyueta Xyueta merged commit 17e4f5b into master Oct 2, 2023
1 of 2 checks passed
@he3als he3als deleted the iso-download branch October 2, 2023 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bypass Bypass Contribution Guildelines getting-started Issues or PRs related to the 'Getting Started' page mkdocs-config Issues or PRs related to the MkDocs configuration
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants