-
-
Notifications
You must be signed in to change notification settings - Fork 556
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Winget Error Checking to Scripts #904
Conversation
This is good, but I'm wondering if the domain that WinGet is trying to pull from to work will ever get changed or if there's other domains required. The message should be changed as well to clarify that the user could have internet, but WinGet is blocked. |
I think that a better alternative might be simply error checking for WinGet. |
Working on it 🫡 |
Is checking if the errorlevel is not 0 and if so say something like installation failed enough? |
3fb3c6c
to
76801c7
Compare
Can you resolve the merge conflicts and add |
Checking rn
Already added that with a5ace16 |
To be fair I don't know how to resolve conflicts in a pr |
Hiding Winget output like in the "Install and replace Task Manager" script
a5ace16
to
df58592
Compare
Figured it out 👍🏻 |
Thank you very much for the PR! |
Questions
dev
branch and notmain
?Note: You should commit directly to
main
for translations of theREADME.md
.Describe your pull request (edited)
Adds Winget error checking in the
Install Open-Shell
andInstall and Replace Task Manager
scriptsThis fixes v03-testing > Install Open-shell script error