Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: build script for Non-English environment #1310

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Dreagonmon
Copy link

Questions

Describe your pull request

fix build script for Non-English environment.

I want to test my modified version of playbook, but the output of the test target seems having a broken xml format.

It turns out that I use the Chinese environment and powershell use the Chinese encoding to read and write playbook.conf file, that would break the Description content which contains special characters.

So here is the fix, simply add -Encoding to the read and write commands.

@Dreagonmon Dreagonmon requested a review from Xyueta as a code owner December 6, 2024 17:04
@github-actions github-actions bot added the playbook Playbook related issues/PRs label Dec 6, 2024
@Dreagonmon Dreagonmon changed the title fix build script for Non-English environment fix: build script for Non-English environment Dec 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playbook Playbook related issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant