Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: services in folder reorganisation, enable all script, misc fixes #1123

Merged
merged 16 commits into from
Jun 14, 2024

Conversation

he3als
Copy link
Contributor

@he3als he3als commented Jun 13, 2024

Questions

Describe your pull request

  • Moves all service scripts that break functionality to 6. Advanced Configuration
    • This is only for service scripts that don't inform the user when attempting to use that feature that it's disabled or is considered experimental
    • Examples of this are Bluetooth, printing, and VPN support
  • Adds a script to re-enable every service in the Atlas folder
    • This is good for troubleshooting when a user has run various service disable scripts in the Atlas folder but doesn't know how to fix their issue
    • This is located both in the 6. Advanced Configuration\Services folder (as a shortcut) and the troubleshooting folder
  • Move folders in the 'Power' folder into the root of general configuration

Other changes

  • Adds silent switches to all the enable service scripts as this is required for the re-enable script
  • Add disable snap layouts tweak (not done by default) for Windows 11
  • Make the themes more reliable using PowerShell; CMD seems to have issues randomly.
  • Make Fax & Scan optional in the enable printing script, as this usually takes lots of time to install
  • Add an option to not re-enable the printing context menu
    • The printing context menu is disabled by default as well

Note

I want 3 reviews on this PR before merging as it's a big change.

@github-actions github-actions bot added the playbook Playbook related issues/PRs label Jun 13, 2024
Copy link
Member

@RadNotRed RadNotRed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Copy link
Member

@the-P1neapple the-P1neapple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job. Well done he3als

@the-P1neapple the-P1neapple merged commit 47526d9 into main Jun 14, 2024
2 checks passed
@he3als he3als deleted the folder-reorganisation branch June 14, 2024 06:18
@PencilNavigator PencilNavigator removed their request for review June 14, 2024 09:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
playbook Playbook related issues/PRs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants