Radiation basics

.clang-format

@@ -15,6 +15,5 @@ SpacesInConditionalStatement: true
 SpacesInParentheses: true
 AlignConsecutiveAssignments: true
 
-BreakBeforeBraces: Allman
+BreakBeforeBraces: Attach
 PointerAlignment: Right
-SortIncludes: Never

CMakeLists.txt

@@ -55,7 +55,7 @@ option(ATHELAS_ENABLE_UNIT_TESTS "Enable unit tests" OFF)
 option(ATHELAS_ENABLE_INTEGRATION_TESTS "Enable integration tests" OFF) # Future
 option(ATHELAS_ENABLE_REGRESSION_TESTS "Enable regression tests" OFF)   # Future
 
-set( MACHINE "UBUNTU" CACHE STRING "Set OS")
+set( MACHINE "LINUX" CACHE STRING "Set OS")
 message( "Building On ${MACHINE} ")
 
 # Don't allow in-source builds
@@ -103,6 +103,7 @@ set( ATHELAS_SOURCES
   "src/EoS/EoS_Ideal.cpp"
   "src/Fluid/FluidUtilities.cpp"
   "src/Radiation/RadUtilities.cpp"
+  "src/Radiation/Rad_Discretization.cpp"
   "src/Fluid/Fluid_Discretization.cpp"
   "src/Geometry/Grid.cpp"
   "src/IO/IOLibrary.cpp"
@@ -190,7 +191,7 @@ if (${MACHINE} STREQUAL UBUNTU)
     target_link_libraries( libathelas ${LAPACK_LIBRARIES} )
 else()
   find_package( LAPACK REQUIRED  )
-  message(STATUS "LAPACK_LIBRARIES = ${LAPACK_LIBRARIES}")
+  message(STATUS "LAPACKE_LIBRARIES = ${LAPACK_LIBRARIES}")
   include_directories(${LAPACK_INCLUDE_DIRS})
     target_link_libraries( libathelas ${LAPACK_LIBRARIES} )
 endif()

README.md

@@ -46,10 +46,26 @@ This will create a directory `bin` in the root directory that contains the execu
 ## NOTE: 
 The build system may not be perfect yet. Your mileage may vary.
 
+## TODO
+- function naming overhaul
+- class accessor refactor
+- cmake: bin into build
+- kokkos parallel slope limiter
+- repalce simpleini reader with different format (TOML, YAML)
+- Rename values in hdf5 output...
+- generalize applyBC for rad and fluid. extents for dims
+
+### Radiation TODO:
+- radiation riemann solver
+- radiation timestepper
+- strang split
+- probably more
+- ... microphysics...
+
 
 # Future Work
 
-- Grey M1 radiation
+- Grey M1 radiation [WIP]
 - Relativistic hydro
 - Gravity
 - Multigroup radiation
@@ -75,6 +91,7 @@ Simply call `tools/bash/format.sh` to format the `.hpp` and `.cpp` files.
  - [ ] New TCI
  - [ ] linter
  - [ ] format on make
+ - [ ] Rad: Riemann solvers beyond LLF?
  - [ ] Adjust numerical fluxes for 1D MHD
  - [ ] Implement 1.5D NRMHD
 

inputs/advection.ini

@@ -0,0 +1,28 @@
+[Problem]
+problem=MovingContact
+t_end=5.0
+geometry=planar;spherical or planar
+restart=false
+do_rad=true
+xL=0.0
+xR=1.0
+BC=Homogenous
+CFL=0.35
+
+[Fluid]
+Basis=Legendre
+nNodes=1
+pOrder=1
+nX=128
+nG=1
+
+[Time]
+tOrder=1
+nStages=1
+
+[Limiters]
+alpha=1.0
+Threshold=0.0
+TCI_Opt=false
+TCI_val=0.1
+Characteristic=true

inputs/radeq.ini

@@ -0,0 +1,28 @@
+[Problem]
+problem=RadEquilibrium
+t_end=1.0e-7
+geometry=planar;spherical or planar
+restart=false
+do_rad=true
+xL=0.0
+xR=1.0
+BC=Homogenous
+CFL=0.35
+
+[Fluid]
+Basis=Legendre
+nNodes=1
+pOrder=1
+nX=256
+nG=1
+
+[Time]
+tOrder=1
+nStages=1
+
+[Limiters]
+alpha=1.0
+Threshold=0.0
+TCI_Opt=false
+TCI_val=0.1
+Characteristic=true

src/BC/BoundaryConditionsLibrary.cpp

@@ -11,13 +11,12 @@
 
 #include "Kokkos_Core.hpp"
 
-#include "Grid.hpp"
 #include "BoundaryConditionsLibrary.hpp"
+#include "Grid.hpp"
 
 // Apply Boundary Conditions to fluid fields
-void ApplyBC( Kokkos::View<Real ***> uCF, GridStructure *Grid,
-              const UInt order, const std::string BC )
-{
+void ApplyBC( Kokkos::View<Real ***> uCF, GridStructure *Grid, const UInt order,
+              const std::string BC ) {
 
   const UInt ilo = Grid->Get_ilo( );
   const UInt ihi = Grid->Get_ihi( );
@@ -26,60 +25,45 @@ void ApplyBC( Kokkos::View<Real ***> uCF, GridStructure *Grid,
   const UInt nG = Grid->Get_Guard( );
 
   // ! ? How to correctly implement reflecting BC ? !
-  if ( BC == "Reflecting" )
-  {
-    for ( UInt iCF = 0; iCF < 3; iCF++ )
-    {
+  if ( BC == "Reflecting" ) {
+    for ( UInt iCF = 0; iCF < 3; iCF++ ) {
       // Inner Boudnary
       for ( UInt iX = 0; iX < ilo; iX++ )
-        for ( UInt k = 0; k < order; k++ )
-        {
-          if ( iCF != 1 )
-          {
+        for ( UInt k = 0; k < order; k++ ) {
+          if ( iCF != 1 ) {
             if ( k == 0 ) uCF( iCF, iX, k ) = +uCF( iCF, ilo, k );
             if ( k != 0 ) uCF( iCF, iX, k ) = -uCF( iCF, ilo, k );
-          }
-          else
-          {
+          } else {
             if ( k == 0 ) uCF( 1, iX, 0 ) = -uCF( 1, ilo, 0 );
             if ( k != 0 ) uCF( 1, iX, k ) = +uCF( 1, ilo, k );
           }
         }
 
       // Outer Boundary
       for ( UInt iX = ihi + 1; iX < nX + 2 * nG; iX++ )
-        for ( UInt k = 0; k < order; k++ )
-        {
-          if ( iCF != 1 )
-          {
+        for ( UInt k = 0; k < order; k++ ) {
+          if ( iCF != 1 ) {
             uCF( iCF, iX, k ) = uCF( iCF, ihi, k );
-          }
-          else
-          {
+          } else {
             uCF( iCF, iX, k ) = -uCF( 1, ihi, k );
           }
         }
     }
-  }
-  else if ( BC == "Periodic" )
-  {
+  } else if ( BC == "Periodic" ) {
     for ( UInt iCF = 0; iCF < 3; iCF++ )
       for ( UInt iX = 0; iX < ilo; iX++ )
-        for ( UInt k = 0; k < order; k++ )
-        {
+        for ( UInt k = 0; k < order; k++ ) {
           uCF( iCF, ilo - 1 - iX, k ) = uCF( iCF, ihi - iX, k );
           uCF( iCF, ihi + 1 + iX, k ) = uCF( iCF, ilo + iX, k );
         }
-  }
-  else if ( BC == "ShocklessNoh" ) /* Special case for ShocklessNoh test */
+  } else if ( BC == "ShocklessNoh" ) /* Special case for ShocklessNoh test */
   {
     // for ( UInt iCF = 0; iCF < 3; iCF++ )
     for ( UInt iX = 0; iX < ilo; iX++ )
       for ( UInt k = 0; k < order; k++ )
       // for ( UInt iCF = 0; iCF < 3; iCF++ )
       {
-        if ( k == 0 )
-        {
+        if ( k == 0 ) {
 
           uCF( 0, ilo - 1 - iX, k ) = uCF( 0, ilo + iX, k );
           uCF( 0, ihi + 1 + iX, k ) = uCF( 0, ihi - iX, k );
@@ -98,9 +82,7 @@ void ApplyBC( Kokkos::View<Real ***> uCF, GridStructure *Grid,
               uCF( 2, ihi - iX, k ) -
               0.5 * uCF( 1, ihi - iX, k ) * uCF( 1, ihi - iX, k ) +
               0.5 * uCF( 1, ihi + 1 + iX, k ) * uCF( 1, ihi + 1 + iX, k );
-        }
-        else if ( k == 1 )
-        {
+        } else if ( k == 1 ) {
           uCF( 0, ilo - 1 - iX, k ) = 0.0;
           uCF( 0, ihi + 1 + iX, k ) = 0.0;
 
@@ -111,9 +93,7 @@ void ApplyBC( Kokkos::View<Real ***> uCF, GridStructure *Grid,
               -uCF( 1, ilo + iX, 0 ) * uCF( 1, ilo + iX, 1 );
           uCF( 2, ihi + 1 + iX, k ) =
               uCF( 1, ihi + 1 + iX, 0 ) * uCF( 1, ihi + 1 + iX, 1 );
-        }
-        else if ( k == 2 )
-        {
+        } else if ( k == 2 ) {
 
           // uCF( iCF, ilo - 1 - iX, k ) = 0.0;
           // uCF( iCF, ihi + 1 + iX, k ) = 0.0;
@@ -130,9 +110,7 @@ void ApplyBC( Kokkos::View<Real ***> uCF, GridStructure *Grid,
               uCF( 2, ilo + iX, 2 ); // * uCF( 1, ilo + iX, 1 );
           uCF( 2, ihi + 1 + iX, k ) =
               uCF( 2, ihi - iX, 2 ); //* uCF( 1, ihi - iX, 1 );
-        }
-        else
-        {
+        } else {
           uCF( 0, ilo - 1 - iX, k ) = 0.0; // uCF( 0, ilo + iX, k );
           uCF( 0, ihi + 1 + iX, k ) = 0.0; // uCF( 0, ihi - iX, k );
 
@@ -143,13 +121,10 @@ void ApplyBC( Kokkos::View<Real ***> uCF, GridStructure *Grid,
           uCF( 2, ihi + 1 + iX, k ) = uCF( 2, ihi - iX, k );
         }
       }
-  }
-  else
-  {
-    for ( UInt iCF = 0; iCF < 3; iCF++ )
+  } else {
+    for ( UInt iCF = 0; iCF < uCF.extent( 0 ); iCF++ )
       for ( UInt iX = 0; iX < ilo; iX++ )
-        for ( UInt k = 0; k < order; k++ )
-        {
+        for ( UInt k = 0; k < order; k++ ) {
           uCF( iCF, ilo - 1 - iX, k ) = uCF( iCF, ilo + iX, k );
           uCF( iCF, ihi + 1 + iX, k ) = uCF( iCF, ihi - iX, k );
         }

src/BC/BoundaryConditionsLibrary.hpp

@@ -1,9 +1,10 @@
-#ifndef BOUNDARYCONDITIONSLIBRARY_H
-#define BOUNDARYCONDITIONSLIBRARY_H
+#ifndef _BOUNDARYCONDITIONSLIBRARY_HPP_
+#define _BOUNDARYCONDITIONSLIBRARY_HPP_
 
 #include "Abstractions.hpp"
+#include "Grid.hpp"
 
-void ApplyBC( Kokkos::View<Real ***> uCF, GridStructure *Grid,
-              const UInt order, const std::string BC );
+void ApplyBC( Kokkos::View<Real ***> uCF, GridStructure *Grid, const UInt order,
+              const std::string BC );
 
-#endif
+#endif // _BOUNDARYCONDITIONSLIBRARY_HPP_