Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved Adaptive Navigation in RYScaffold #877

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

kdroidFilter
Copy link

Summary

This PR improves RYScaffold to better handle adaptive navigation

Conditional Bottom Bar: Uses NavigationSuiteScaffold only if navigationSuiteItems are present, avoiding empty bars on mobile.

Adaptive Integration: Updated FilterBar for adaptive behavior based on screen size.

Future Improvement

Consider repositioning the settings button on the home page.

Updated several pages and components to use the Adaptive Navigation Suite for a more responsive and consistent UI layout.
Modify RYScaffold to use NavigationSuiteScaffold only when navigationSuiteItems is not null, otherwise default to using Scaffold. This ensures appropriate usage of components based on the availability of navigationSuiteItems while maintaining UI consistency.
@Ashinch Ashinch requested a review from JunkFood02 November 14, 2024 18:59
@JunkFood02
Copy link
Collaborator

Do you have any screenshot or screen record for this change?

@kdroidFilter
Copy link
Author

kdroidFilter commented Nov 16, 2024

image
According to material 3 conventions, it is not recommended to use a bottom bar on large screens.

@JunkFood02
Copy link
Collaborator

According to material 3 conventions, it is not recommended to use a bottom bar on large screens.

This's true, but instead of just replacing the component, I'd prefer a redesigned layout for large screens. And your screenshot looks no better than a bottom navigation bar ux wise imo

@kdroidFilter
Copy link
Author

Yes I also think that it should not be merged like that, but I thought that it was already a good starting point

@JunkFood02
Copy link
Collaborator

I agree that we should probably make a better navigation for large screens. However, I think the bottom bar here doesn't apply to the guidelines because it's a filter bar, not a navigation bar. It changes the current state of the screen instead of navigating users to another screen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants