Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactorings & MakerNote support preparations #64

Merged
merged 66 commits into from
Jan 26, 2024
Merged

Refactorings & MakerNote support preparations #64

merged 66 commits into from
Jan 26, 2024

Conversation

StefanOltmann
Copy link
Member

  • Refactored APIs for more streamlined code
  • Improved RAW support
  • Prepared MakerNote support

@StefanOltmann
Refactored FieldType subclasses into objects
aeb03a9
@StefanOltmann
Further refactoring on FieldTypes
0354fdb
@StefanOltmann
Support writing single and multiple values again
a966c33
@StefanOltmann
Introduced RationalNumbers.kt
78c93af
@StefanOltmann
Removed constants from FieldType companion object
754c320
@StefanOltmann
Removed TagInfoShortOrLong
f0e5e4e
@StefanOltmann
Removed TagInfoShortOrLongOrRational
41b60a5
@StefanOltmann
Removed TagInfoShortOrLongOrRational
dc1f73c
@StefanOltmann
Removed TagInfoShortOrRational
666b8dc
@StefanOltmann
Removed TagInfoAsciiOrByte
00daaa2
@StefanOltmann
Removed TagInfoAsciiOrRational
69ffa17
@StefanOltmann
Removed TagInfoByteOrShort
7e3c35d
@StefanOltmann
Refactor: Every TagInfo should only have a single fieldType
83e7fc0
@StefanOltmann
Removed unused class TextEncoding
6e4f9f3
@StefanOltmann
Fixed directory for EXIF ImageRating
42dc34a
@StefanOltmann
Removed TagInfo.encodeValue()
13cc21b
@StefanOltmann
Removed TagInfo.getValue()
2c7f79f
@StefanOltmann
Made TagInfo abstract
374fd50
@StefanOltmann
Removed "open" modifier
a776282
@StefanOltmann
Removed indirection over TagInfo.encodeValue() for TiffOutputDirectory
a53556e
@StefanOltmann
Removed "Unknown" field type which served as NULL object.
04fcda2
@StefanOltmann
TiffOutputDirectory formatted.
9d867b8
@StefanOltmann
Removed FIXME comments
2e48b5e
@StefanOltmann
Used constant for unknown length
fe8f16d
@StefanOltmann
Refactor: Moved some logic into TiffContents
5965657
@StefanOltmann
Quick access method for maker note data
2ac353e
@StefanOltmann
Removed oddity that may lead to bugs
26b7c60
@StefanOltmann
Removed empty space
de540f3
@StefanOltmann
Removed HTML dumps
0649472
@StefanOltmann
Removed TiffReaderCollector
de0b680
@StefanOltmann
README.md: Added a note about MakerNote support
be8fac6
@StefanOltmann
TiffReader.kt: Moved experimental MakerNote stuff to the end of file.
ce1a3d3
@StefanOltmann
Updated limitations section of README.md
bf2ba44
@StefanOltmann
Use constant
42474a8
@StefanOltmann
Change parameter name
c2096c3
@StefanOltmann
Removed parentheses
d4f9749
@StefanOltmann
Unused directory removed
c62b927
@StefanOltmann
TiffTags.kt: Priority for EXIF tag names
1491a48
@StefanOltmann
More Nikon MakerNote tags
50069d5
@StefanOltmann
Updated README.md on Nikon files
ab5bdc7
@StefanOltmann
Renamed ExifImageLength -> ExifImageHeight
d7eff40
@StefanOltmann
Fix for Sony ARW: Prefer the image size set in ExifImageWidth & ExifI…
6f24445 
…mageHeight
@StefanOltmann
Rework TiffDirectoryType
323499f
@StefanOltmann
Updated README.md
a967b83
@StefanOltmann
Refreshed metadata.csv
1132b30
@StefanOltmann
Fix: Keep MakerNote directory separate
c1c1c32
@StefanOltmann
Call the ISO field simply "ISO" as ExifTool does
bcdc755
@StefanOltmann
Fix: Read ISO value for RW2 files
2bf0109
@StefanOltmann
Clarifications in README.md
8dd67f7
@StefanOltmann
Clarifications in README.md
3c7252b
@StefanOltmann
Clarifications in README.md
873de57
@StefanOltmann
Refactor TagInfo: Tag should come first as this is more common.
ebb778d
@StefanOltmann
Formatting
a565aba
@StefanOltmann
Removed unused constant
79a850f
@StefanOltmann
Fixed law of demeter issue
f7ca844
@StefanOltmann
Bump version number
648a375
@StefanOltmann StefanOltmann enabled auto-merge (squash) January 26, 2024 10:47
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 26, 2024

Quality Gate Failed Quality Gate failed

Failed conditions

75.2% Coverage on New Code (required ≥ 80%)

See analysis details on SonarCloud

@StefanOltmann StefanOltmann merged commit adf017b into main Jan 26, 2024
1 of 2 checks passed
@StefanOltmann StefanOltmann deleted the tiff_fields_refactor branch January 26, 2024 11:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@StefanOltmann