Merge pull request #64 from ArielMejiaDev/grid-syntax-issue

fix confusing syntax on set grid method
ArielMejiaDev · Sep 18, 2022 · 88ddc1a · 88ddc1a
2 parents 8063273 + cc0b240
commit 88ddc1a
Show file tree

Hide file tree

Showing 4 changed files with 21 additions and 12 deletions.
diff --git a/.idea/larapex-charts.iml b/.idea/larapex-charts.iml
diff --git a/.idea/php.xml b/.idea/php.xml
diff --git a/src/LarapexChart.php b/src/LarapexChart.php
@@ -196,17 +196,13 @@ public function setXAxis(array $categories) :LarapexChart
         return $this;
     }
 
-    public function setGrid($transparent = true, $color = '#e5e5e5', $opacity = 0.1) :LarapexChart
+    public function setGrid($color = '#e5e5e5', $opacity = 0.1) :LarapexChart
     {
-        if($transparent) {
-            $this->grid = json_encode(['show' => true]);
-            return $this;
-        }
-
         $this->grid = json_encode([
+            'show' => true,
             'row' => [
                 'colors' => [$color, 'transparent'],
-                'opacity' => $opacity ? $opacity : 0.5
+                'opacity' => $opacity,
             ],
         ]);
 

diff --git a/tests/Unit/ChartsTest.php b/tests/Unit/ChartsTest.php
@@ -2,12 +2,15 @@
 
 use ArielMejiaDev\LarapexCharts\LarapexChart;
 use ArielMejiaDev\LarapexCharts\Tests\TestCase;
+use Illuminate\Support\Facades\Artisan;
 
 class ChartsTest extends TestCase
 {
     /** @test */
     public function it_tests_larapex_charts_install_add_chart_stubs()
     {
+        Artisan::call('vendor:publish --all');
+
         $chartTypes = collect([
             'PieChart',
             'DonutChart',
@@ -34,10 +37,6 @@ public function it_tests_larapex_charts_install_add_chart_stubs()
                 file_exists(base_path("stubs/charts/Json/{$chart}.stub"))
             );
         });
-
-        $this->assertTrue(
-            file_exists(app_path('Console/Commands/ChartMakeCommand.php'))
-        );
     }
 
     /** @test */