Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AP_DDS: Publish GPS sensor transform with ROS 2 static transform broadcaster #23393

Closed
Ryanf55 opened this issue Apr 4, 2023 · 1 comment
Closed
Assignees
Labels
For-4.5 Planned for 4.5 release ROS

Comments

@Ryanf55
Copy link
Collaborator

Ryanf55 commented Apr 4, 2023

Feature request

Is your feature request related to a problem? Please describe.
Right now, AP_DDS publishes the location of the first GPS receiver. The LLA coordinates are in the frame of the GPS. In order to do any fusion of this GPS, the location of it relative to the aircraft origin needs to be known by the companion computer.

Describe the solution you'd like
AP_DDS implements a static transform broadcaster. Using the following params, publish the transforms, on boot. If params are updated at runtime, re-publish the static transform. Abide by ROS 2 QoS for transform broadcaster.

  • GPS_POS1_X
  • GPS_POS1_Y
  • GPS_POS1_Z
  • GPS_POS2_X
  • GPS_POS2_Y
  • GPS_POS2_Z

Since there are no orientation params for the GPS, assume it's pointing up and also assume that any rotational offset is negligible to the solution

Describe alternatives you've considered
Exposing the params over DDS and letting the consumer query them directly.

Platform
[x ] All
[ ] AntennaTracker
[ ] Copter
[ ] Plane
[ ] Rover
[ ] Submarine

Additional context

https://docs.ros.org/en/humble/Tutorials/Intermediate/Tf2/Writing-A-Tf2-Static-Broadcaster-Cpp.html

Dependencies
#23277
#23259

@Ryanf55 Ryanf55 added ROS For-4.5 Planned for 4.5 release labels Apr 4, 2023
@Ryanf55 Ryanf55 added this to DDS/ROS2 Apr 4, 2023
@Ryanf55 Ryanf55 self-assigned this Apr 5, 2023
@Ryanf55 Ryanf55 moved this to 🏗 In progress in DDS/ROS2 Apr 5, 2023
@Ryanf55 Ryanf55 moved this from 🏗 In progress to ✅ Done in DDS/ROS2 Apr 14, 2023
@srmainwaring
Copy link
Contributor

Closed by #23412

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
For-4.5 Planned for 4.5 release ROS
Projects
Status: Done
Development

No branches or pull requests

2 participants