-
Notifications
You must be signed in to change notification settings - Fork 2.7k
Add higher baudrates to connection-options box #3649
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull request overview
This PR expands the available baudrate options in the connection settings dialog by adding support for higher baudrates up to 1.5 Mbit/s, along with some lower baudrates for improved device compatibility.
- Adds 9 new higher baudrate options (230400, 460800, 500000, 625000, 921600, 1000000, 1500000) to support modern high-speed serial devices
- Adds 2 lower baudrate options (1200, 2400) for legacy device support
- Removes 14400 baudrate from the original list
- Updates both the resource file and designer code to accommodate the expanded baudrate selection
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| Controls/ConnectionOptions.resx | Updated baudrate combo box items from 8 to 17 entries, adding higher baudrates up to 1.5 Mbit/s and lower baudrates for legacy support |
| Controls/ConnectionOptions.Designer.cs | Updated InitializeComponent method to reference all 17 baudrate items from the resource file |
Files not reviewed (1)
- Controls/ConnectionOptions.Designer.cs: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| resources.GetString("CMB_baudrate.Items5"), | ||
| resources.GetString("CMB_baudrate.Items6"), | ||
| resources.GetString("CMB_baudrate.Items7"), | ||
| resources.GetString("CMB_baudrate.Items8"), |
Copilot
AI
Dec 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The designer code correctly references Items8 which corresponds to the invalid baudrate value "111100" in the resource file. Once the baudrate issue in the resx file is resolved (either by removing or correcting the value), ensure this reference is also updated accordingly.
| resources.GetString("CMB_baudrate.Items8"), |
| <data name="CMB_baudrate.Items8" xml:space="preserve"> | ||
| <value>111100</value> | ||
| </data> |
Copilot
AI
Dec 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The baudrate value "111100" is not a standard serial communication baudrate. This appears to be a typo or error. Standard baudrates typically follow powers of 2 or specific increments. Common baudrates in this range include 115200 (which is already in the list). Consider removing this entry or correcting it to a valid standard baudrate if a different value was intended.
| <data name="CMB_baudrate.Items8" xml:space="preserve"> | |
| <value>111100</value> | |
| </data> |
| </data> | ||
| <data name="CMB_baudrate.Items16" xml:space="preserve"> | ||
| <value>1500000</value> | ||
| </data> |
Copilot
AI
Dec 27, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The standard baudrate 14400 was removed from the original list but is still a valid and commonly used baudrate for certain modem communications. Consider keeping this baudrate option for backwards compatibility with devices that may use it.
| </data> | |
| </data> | |
| <data name="CMB_baudrate.Items17" xml:space="preserve"> | |
| <value>14400</value> | |
| </data> |
Up to 1.5Mbit/s