Fix prefetch bug - null reference in TilePrefetcherMenu #3634
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… set from Flight Modes panel
- Update IsVehicleConnected to check for valid lat/lng coordinates - Add location validation to FlightData before updating Map3D - Prevents 3D map from centering on 0,0 when connected but no GPS fix
Brings in: - Tile loading algorithm improvements with weighted distance/zoom scoring - 500MB tile cache - Valid GPS location check (not 0,0) before tracking vehicle - Disconnected mode camera and tile loading improvements - Motor test smart assign swap feature Keeps STLModelLoader with default STL selection based on MAV_TYPE
- Enable smooth fractional zoom scrolling for all maps - Use camera position for 3D map tile generation - Set ScaleMode to Fractional for smoother zooming
Development merge
robertlong13
reviewed
Dec 8, 2025
Comment on lines
-22
to
-23
| numericUpDownMinZoom.Minimum = numericUpDownMaxZoom.Minimum = trackBarMinZoom.Minimum = trackBarMaxZoom.Minimum = min; | ||
| numericUpDownMinZoom.Maximum = numericUpDownMaxZoom.Maximum = trackBarMinZoom.Maximum = trackBarMaxZoom.Maximum = max; |
Collaborator
There was a problem hiding this comment.
Revert this change. I don't think moving these two lines down has anything to do with it. This PR should just be adding an isInitialized flag.
Collaborator
|
Also fix up the commit message |
MohammadAdib
force-pushed
the
fix-tileprefetcher-null-reference
branch
from
46eef54 to
ab67395
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
TilePrefetcherMenu.cswhenOverlayis nullOverlay.Polygonsto prevent crash during tile prefetch operationsTest plan