Skip to content

Conversation

Copy link
Contributor

Copilot AI commented Nov 25, 2025

What does this PR do?

Fixes copyright header placement in IndexMetadata.java and LSMVectorIndexMetadata.java. Headers were incorrectly placed after the package statement and imports. Now follows standard Java convention with headers at file start, including SPDX identifiers.

Motivation

Addresses feedback from PR #2828 code review regarding improper copyright header positioning.

Related issues

Additional Notes

Both files now match the standard format used throughout the codebase:

  • Copyright header at file start
  • SPDX-FileCopyrightText and SPDX-License-Identifier included
  • Package statement follows header
  • Imports follow package

Checklist

  • I have run the build using mvn clean package command
  • My unit tests cover both failure and success scenarios

✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

Copy link
Contributor Author

Copilot AI commented Nov 25, 2025

Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details.

Warning

Firewall rules blocked me from connecting to one or more addresses (expand for details)

I tried to connect to the following addresses, but was blocked by firewall rules:

  • repository.apache.org
    • Triggering command: /usr/lib/jvm/temurin-17-jdk-amd64/bin/java /usr/lib/jvm/temurin-17-jdk-amd64/bin/java -classpath /home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1/boot/plexus-classworlds-2.8.0.jar -Dclassworlds.conf=/home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1/bin/m2.conf -Dmaven.home=/home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1 -Dlibrary.jansi.path=/home/REDACTED/.m2/wrapper/dists/apache-maven-3.9.9/3477a4f1/lib/jansi-native -Dmaven.multiModuleProjectDirectory=/home/REDACTED/work/arcadedb/arcadedb org.codehaus.plexus.classworlds.launcher.Launcher -f pom.xml -B -V -e -Dfindbugs.skip -Dcheckstyle.skip -Dpmd.skip=true -Dspotbugs.skip -Denforcer.skip -Dmaven.javadoc.skip -DskipTests (dns block)

If you need me to access, download, or install something from one of these locations, you can either:

Copilot AI changed the title [WIP] Address feedback from PR #2828 on index refactoring Fix copyright header placement in IndexMetadata and LSMVectorIndexMetadata Nov 25, 2025
Copilot AI requested a review from lvca November 25, 2025 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants