-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
macOS updates #15
base: main
Are you sure you want to change the base?
macOS updates #15
Conversation
Warning, untested.
Update link on the Credits read-me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good so far, although it doesn't start for me at the moment.
I've left some initial review comments - some of it is likely needed to get it working, while others are just suggestions to make future maintenance easier.
#define KB_BUFFER_SIZE 20 | ||
#define KEY_UP 1 | ||
#define KEY_DOWN 0 | ||
#define KB_BUFFER_SIZE 20 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Given that the keyboard emulation code is now using a circular buffer internally, it should hopefully be possible to get rid of the second circular buffer in the frontend code.
Also remove the memsets: -initWithLength: already zeroes out the memory.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With a few extra modifications, I can now get the main window to open and access the menu options. The graphics for the main display don't work however, but you can still lock the mouse pointer and see the cursor graphic moving.
I've pushed some changes to the branch, which allow video output to work correctly. |
This is based off of my work here: https://github.com/MaddTheSane/arcem
There's no guarantee that this will work, but it does build (when using Xcode).