Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

macOS updates #15

Open
wants to merge 17 commits into
base: main
Choose a base branch
from
Open

macOS updates #15

wants to merge 17 commits into from

Conversation

MaddTheSane
Copy link
Contributor

  • Remove old Xcode/ProjectBuilder build files.
  • Migrate from ProjectBuilder project to Xcode project.
  • Use Xcode assets for the icon
  • Convert nibs to xibs: They're more diff-friendly.
  • Remove big-endian defines: x86_64 and ARM64, the current targets, are little-endian.
  • Convert a lot of the Cocoa code to ARC.

This is based off of my work here: https://github.com/MaddTheSane/arcem
There's no guarantee that this will work, but it does build (when using Xcode).

Copy link
Member

@ccawley2011 ccawley2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far, although it doesn't start for me at the moment.

I've left some initial review comments - some of it is likely needed to get it working, while others are just suggestions to make future maintenance easier.

macosx/ArcemController.m Outdated Show resolved Hide resolved
macosx/ArcemController.m Show resolved Hide resolved
#define KB_BUFFER_SIZE 20
#define KEY_UP 1
#define KEY_DOWN 0
#define KB_BUFFER_SIZE 20
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that the keyboard emulation code is now using a circular buffer internally, it should hopefully be possible to get rid of the second circular buffer in the frontend code.

macosx/DispKbd.c Outdated Show resolved Hide resolved
macosx/filecalls_internal.h Outdated Show resolved Hide resolved
macosx/sound.c Outdated Show resolved Hide resolved
macosx/DispKbd.c Outdated Show resolved Hide resolved
Copy link
Member

@ccawley2011 ccawley2011 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

With a few extra modifications, I can now get the main window to open and access the menu options. The graphics for the main display don't work however, but you can still lock the mouse pointer and see the cursor graphic moving.

macosx/DispKbd.c Outdated Show resolved Hide resolved
macosx/DispKbd.c Show resolved Hide resolved
macosx/ArcemController.m Show resolved Hide resolved
@ccawley2011
Copy link
Member

I've pushed some changes to the branch, which allow video output to work correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants