Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: gql request crashs when formatting scalar args #173

Merged
merged 4 commits into from
Sep 26, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 0.34.3 (September 26, 2023)
- fix: gql request crashes when formatting scalar args

## 0.34.2 (September 26, 2023)
- fix: gql request crashes when formatting scalar args

Expand Down
2 changes: 1 addition & 1 deletion packages/sdk-util/src/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -190,7 +190,7 @@ const formatArgs = (values, specs = {}) => {

// escape slash(\) and double quotes (")
if ('String' === type) {
const container = isNull(value) ? null : (value || '').includes('\n') ? '"""' : '"';
const container = isNull(value) ? null : String(value).includes('\n') ? '"""' : '"';

return isNull(value) ? null : `${container}${value
.toString()
Expand Down
15 changes: 15 additions & 0 deletions packages/sdk-util/test/util.spec.js
Original file line number Diff line number Diff line change
Expand Up @@ -107,6 +107,21 @@ describe('#formatArgs', () => {
expect(args).toEqual('address: "xxx", height: 123');
});

test('should process scalar types correctly (has break line)', () => {
const args = formatArgs({ address: 'ab\ncd', height: 123 }, specs);
expect(args).toEqual('address: """ab\ncd""", height: 123');
});

test('should process scalar types correctly (object in string)', () => {
const args = formatArgs({ address: { name: 'abc' }, height: 123 }, specs);
expect(args).toEqual('address: "[object Object]", height: 123');
});

test('should process scalar types correctly (null)', () => {
const args = formatArgs({ address: null, height: 123 }, specs);
expect(args).toEqual('address: null, height: 123');
});

test('should process null scalar values correctly', () => {
const args = formatArgs({ address: null, height: 123 }, specs);
expect(args).toEqual('address: null, height: 123');
Expand Down
2 changes: 1 addition & 1 deletion version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.34.2
0.34.3
Loading