Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: input string can have line breaks in gql query #170

Merged
merged 4 commits into from
Sep 25, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
## 0.34.1 (September 25, 2023)
- fix: input string should can have \n in gql query

## 0.34.0 (April 27, 2023)

- fix(sdk): should not throw error when format null value for scalar
Expand Down
2 changes: 1 addition & 1 deletion Makefile
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ install:

dep:
@echo "Install dependencies required for this repo..."
@lerna bootstrap
@yarn

pre-build: install dep
@echo "Running scripts before the build..."
Expand Down
8 changes: 4 additions & 4 deletions packages/sdk-util/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -14,17 +14,17 @@
"wangshijun <[email protected]> (https://ocap.arcblock.io)"
],
"dependencies": {
"cross-fetch": "^3.1.5",
"cross-fetch": "^3.1.8",
"debug": "^4.3.4",
"graphql": "16.5.0",
"lodash.get": "^4.4.2",
"lodash.isnull": "^3.0.0",
"lodash.set": "^4.3.2"
},
"devDependencies": {
"@babel/cli": "^7.18.10",
"@babel/core": "^7.18.10",
"@babel/preset-env": "^7.18.10",
"@babel/cli": "^7.22.9",
"@babel/core": "^7.22.9",
"@babel/preset-env": "^7.22.9",
"eslint": "^5.16.0",
"eslint-config-prettier": "latest",
"eslint-plugin-prettier": "latest",
Expand Down
6 changes: 4 additions & 2 deletions packages/sdk-util/src/util.js
Original file line number Diff line number Diff line change
Expand Up @@ -190,10 +190,12 @@ const formatArgs = (values, specs = {}) => {

// escape slash(\) and double quotes (")
if ('String' === type) {
return isNull(value) ? null : `"${value
const container = isNull(value) ? null : value.includes('\n') ? '"""' : '"';

return isNull(value) ? null : `${container}${value
.toString()
.replace(/\\/g, '\\\\')
.replace(/"/g, '\\"')}"`;
.replace(/"/g, '\\"')}${container}`;
}

if (['DateTime', 'ID', 'HexString'].includes(type)) {
Expand Down
2 changes: 1 addition & 1 deletion version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
0.34.0
0.34.1
Loading
Loading