Feature/461 semester progress android widget #1051
Conversation
|
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| android:name="android.appwidget.provider" | ||
| android:resource="@xml/semester_progress_widget_info"/> | ||
| </receiver> | ||
| <activity |
Check warning
Code scanning / SonarCloud
Exported component access should be restricted with appropriate permissions Medium
|
Est-ce que c'est possible d'utiliser les settings de l'application ou au minimum les settings du téléphone au lieu d'avoir des settings pour le widget ? |
J'imagine que oui. Je vais tenter de faire ça ce weekend. EDIT: C'est fait! |
…droid-widget' into feature/461-semester-progress-android-widget
android/app/src/main/kotlin/ca/etsmtl/applets/etsmobile/services/MonETSService.kt
Outdated
Show resolved
Hide resolved
android/app/src/main/kotlin/ca/etsmtl/applets/etsmobile/Constants.kt
Outdated
Show resolved
Hide resolved
android/app/src/main/kotlin/ca/etsmtl/applets/etsmobile/services/SignetsService.kt
Outdated
Show resolved
Hide resolved
android/app/src/main/kotlin/ca/etsmtl/applets/etsmobile/services/SignetsService.kt
Outdated
Show resolved
Hide resolved
android/app/src/main/kotlin/ca/etsmtl/applets/etsmobile/services/SignetsService.kt
Outdated
Show resolved
Hide resolved
|
Also, when not connected, the default text should be N/A, for now it's null on the x% progress. Also, the language should follow the app language, just like the theme. The text |
|
J'ai pas encore pris le temps de regarder le code, mais je l'ai testé. Pour le i18n comment ça se passe? Mon cell est en anglais mais l'app en français, le widget s'affiche en anglais. Est ce que on ne voudrait pas plutot utiliser la langue de l'app. Aussi, le changement entre light mode et dark mode est pas super smooth. |
|
|
This PR exceeds the recommended size of 1000 lines. Please make sure you are NOT addressing multiple issues with one PR. Note this PR might be rejected due to its size. |
|
#461
📖 Description
This PR introduces the semester progress home screen widget for android.
The widget behaves the same way as in the application.
The widget is re-sizable and displays a circular progress bar when the widget is small enough.
The theme/language of the widget matches the application theme/language.
See the screen recording if needed.
🧪 How Has This Been Tested?
Manual testing and day to day use.
☑️ Checklist before requesting a review
version: Major,version: Minororversion: Patch.🖼️ Screenshots (if useful):